public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <phurley@charter.net>
To: Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: Fix for audio stream XCASE connect:connect failures
Date: Wed, 09 Sep 2009 11:49:23 -0400	[thread overview]
Message-ID: <4AA7CE83.8010509@charter.net> (raw)
In-Reply-To: <20090908222839.GA25653@jh-x301>

Johan Hedberg wrote:
> That's some really nice analysis of the situation you've done.
Thanks.
> - Use /* .. */ for comments instead of //
> - Make sure your lines are max 80 columns (e.g. shorten the debug message
>   or split it into two lines if necessary)
> - commit it to your own tree with a descriptive commit message and prepare
>   a patch using "git format-patch". This way it's easy for me to apply it
>   using "git am" and e.g. the author field gets correctly preserved.
>   
Sorry about the style snafus: that's fixed, committed & the patch has 
been generated.  Since I use T-bird as my email client and that doesn't 
seem to be going too well with inline patches, I'm setting up Postfix so 
I can use git send-email.  Just need to get SMTP AUTH working with my ISP...

Luiz Augusto von Dentz wrote:
> ........................ please also make sure the DBus
> signals are right, which in this case means we shouldn't emit
> disconnected when dropping the second connection attempt, you can use
> dbus-monitor --system sender='org.bluez'.
>   
I will be sure to double-check that before I mail the patch.  (Shouldn't 
be a problem because the state change to _CONNECTING on the duplicate 
connect attempt never happens).

Regards,
Peter

  parent reply	other threads:[~2009-09-09 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 20:57 Fix for audio stream XCASE connect:connect failures Peter Hurley
2009-09-08 22:28 ` Johan Hedberg
2009-09-09 12:32   ` Luiz Augusto von Dentz
2009-09-09 15:49   ` Peter Hurley [this message]
2009-09-09 17:25   ` [PATCH 1/1] Fixed duplicate attempt from device to connect 'signalling' channel Peter Hurley
2009-09-09 17:55     ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA7CE83.8010509@charter.net \
    --to=phurley@charter.net \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox