[PATCH 0/2] Install btattach with "make install"

[PATCH 0/2] Install btattach with "make install"

[John Keeping]

Following a discussion last week [1], it seems that btattach should be
used in preference to hciattach when possible.  This series adds a
manual page for it and updates the makefile so that btattach is
installed via the standard mechanism.

For now, btattach is still marked as experimental so it wil only be
built and installed when experimental features are enabled.

[1] http://article.gmane.org/gmane.linux.bluez.kernel/65807

John Keeping (2):
  tools/btattach: add manual page
  tools/btattach: install during "make install"

 Makefile.tools   |  8 +++++++-
 tools/btattach.1 | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 1 deletion(-)
 create mode 100644 tools/btattach.1

-- 
2.6.3.462.gbe2c914

[PATCH 1/2] tools/btattach: add manual page

[John Keeping]

---
 tools/btattach.1 | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 tools/btattach.1

diff --git a/tools/btattach.1 b/tools/btattach.1
new file mode 100644
index 0000000..ffd653d
--- /dev/null
+++ b/tools/btattach.1
@@ -0,0 +1,53 @@
+.TH "btattach" "1" "November 2015" "BlueZ" "Linux System Administration"
+.SH NAME
+btattach \- attach serial devices to BlueZ stack
+
+.SH SYNOPSIS
+.B btattach
+.RB [\| \-B
+.IR device \|]
+.RB [\| \-A
+.IR device \|]
+.RB [\| \-P
+.IR protocol \|]
+.RB [\| \-R \|]
+
+.SH DESCRIPTION
+.LP
+btattach is used to attach a serial UART to the Bluetooth stack as a
+transport interface.
+
+.SH OPTIONS
+.TP
+.BI \-B " device" , " " \--bredr " device"
+Attach a BR/EDR controller.
+.TP
+.BI \-A " device" , " " \--amp " device"
+Attach an AMP controller.
+.TP
+.BI \-P " protocol" , " " \--protocol " protocol"
+Specify the protocol type for talking to the device.
+Supported values are:
+.RS
+.IP \(bu 2
+.B h4
+.IP \(bu 2
+.B bcsp
+.IP \(bu 2
+.B 3wire
+.IP \(bu 2
+.B h4ds
+.IP \(bu 2
+.B ll
+.IP \(bu 2
+.B ath3k
+.IP \(bu 2
+.B intel
+.IP \(bu 2
+.B bcm
+.IP \(bu 2
+.B qca
+.RE
+.TP
+.B \-R
+Set the device into raw mode (the kernel and bluetoothd will ignore it).
-- 
2.6.3.462.gbe2c914

[PATCH 2/2] tools/btattach: install during "make install"

[John Keeping]

btattach provides access to some line disciplines that are supported by
hciattach, so allow it to be installed and not reserved for developer
use.  For now it is still considered an experimental feature.
---
 Makefile.tools | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Makefile.tools b/Makefile.tools
index 034790a..e79b53b 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -250,10 +250,12 @@ EXTRA_DIST += tools/hid2hci.1
 endif
 
 if EXPERIMENTAL
+bin_PROGRAMS += tools/btattach
+
 noinst_PROGRAMS += tools/bdaddr tools/avinfo tools/avtest \
 			tools/scotest tools/amptest tools/hwdb \
 			tools/hcieventmask tools/hcisecfilter \
-			tools/btinfo tools/btattach \
+			tools/btinfo \
 			tools/btsnoop tools/btproxy \
 			tools/btiotest tools/bneptest tools/mcaptest \
 			tools/cltest tools/oobtest tools/seq2bseq \
@@ -330,7 +332,11 @@ tools_btgatt_server_SOURCES = tools/btgatt-server.c src/uuid-helper.c
 tools_btgatt_server_LDADD = src/libshared-mainloop.la \
 						lib/libbluetooth-internal.la
 
+dist_man_MANS += tools/btattach.1
+
 EXTRA_DIST += tools/bdaddr.1
+else
+EXTRA_DIST += tools/btattach.1
 endif
 
 if READLINE
-- 
2.6.3.462.gbe2c914

Re: [PATCH 0/2] Install btattach with "make install"

[John Keeping]

On Wed,  2 Dec 2015 10:34:58 +0000, John Keeping wrote:

> Following a discussion last week [1], it seems that btattach should be
> used in preference to hciattach when possible.  This series adds a
> manual page for it and updates the makefile so that btattach is
> installed via the standard mechanism.
> 
> For now, btattach is still marked as experimental so it wil only be
> built and installed when experimental features are enabled.
> 
> [1] http://article.gmane.org/gmane.linux.bluez.kernel/65807

Ping?  Does anyone have any feedback on this?

> John Keeping (2):
>   tools/btattach: add manual page
>   tools/btattach: install during "make install"
> 
>  Makefile.tools   |  8 +++++++-
>  tools/btattach.1 | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 1 deletion(-)
>  create mode 100644 tools/btattach.1

Re: [PATCH 0/2] Install btattach with "make install"

[Johan Hedberg]

Hi John,

On Thu, Dec 10, 2015, John Keeping wrote:
> > Following a discussion last week [1], it seems that btattach should be
> > used in preference to hciattach when possible.  This series adds a
> > manual page for it and updates the makefile so that btattach is
> > installed via the standard mechanism.
> > 
> > For now, btattach is still marked as experimental so it wil only be
> > built and installed when experimental features are enabled.
> > 
> > [1] http://article.gmane.org/gmane.linux.bluez.kernel/65807
> 
> Ping?  Does anyone have any feedback on this?

Sorry for the delay. Both patches look good and have now been applied to
bluez.git. Thanks.


Johan