[PATCH BlueZ v1 04/27] iso-tester: Fix leaking socket watches

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

iso_recv_data() clears io_id[0] on entry, but returns TRUE to keep its
watch while more data is expected, so the watch can no longer be
removed, and the watches with ids are only removed when the test data is
freed at exit. Either way the watched socket stays open past the test,
and once it hangs up, as the controller is removed, it wakes up the main
loop over and over for every following test, as G_IO_IN does not
include G_IO_HUP.

Keep the id while the watch is kept and remove the watches on post
teardown. This busy loop is costly under User Mode Linux time travel,
where computing takes no simulated time, e.g. the PAST Receiver tests
took about 7 seconds each, with -T:

  iso-tester  before  49.2 s
              after   16.3 s

Assisted-by: Claude:claude-opus-5-5
---
 tools/iso-tester.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index fe27eaaf34bf..d610b3c32c51 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -707,10 +707,22 @@ static void io_free(void *data)
 static void test_post_teardown(const void *test_data)
 {
 	struct test_data *data = tester_get_data();
+	unsigned int i;
 
 	if (data->io_queue)
 		queue_remove_all(data->io_queue, NULL, NULL, io_free);
 
+	/* Remove the watches with the test, as the sockets they keep open
+	 * hang up once the controller is removed, which would wake up the
+	 * main loop over and over for the following tests.
+	 */
+	for (i = 0; i < ARRAY_SIZE(data->io_id); ++i) {
+		if (data->io_id[i] > 0) {
+			g_source_remove(data->io_id[i]);
+			data->io_id[i] = 0;
+		}
+	}
+
 	mgmt_send(data->mgmt, MGMT_OP_SET_EXP_FEATURE, MGMT_INDEX_NONE,
 		  sizeof(reset_iso_socket_param), reset_iso_socket_param,
 		  NULL, NULL, NULL);
@@ -2542,9 +2554,11 @@ static gboolean iso_recv_data(GIOChannel *io, GIOCondition cond,
 
 	if (memcmp(buf, isodata->recv->iov_base, ret))
 		tester_test_failed();
-	else if (data->step)
+	else if (data->step) {
+		/* Keep the watch, and its id so teardown can remove it */
+		data->io_id[0] = g_source_get_id(g_main_current_source());
 		return TRUE;
-	else if (isodata->disconnect)
+	} else if (isodata->disconnect)
 		iso_shutdown(data, io);
 	else if (isodata->terminate)
 		iso_terminate(data, io);
-- 
2.56.0