[PATCH BlueZ v1 06/27] iso-tester: Fix busy waiting in PAST tests

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

iso_pollout() kept its watch while the connection to the PAST receiver
was missing, but the socket is writable all along, so the main loop was
woken up until the connection was established. Under User Mode Linux
time travel, where computing takes no simulated time, the PAST Info
tests took about 400 seconds each.

Drop the watch instead and send from iso_new_conn() once the connection
is there.

Assisted-by: Claude:claude-opus-5-5
---
 tools/iso-tester.c | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index d610b3c32c51..7149232d17f4 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -471,6 +471,7 @@ struct test_data {
 	uint16_t handle;
 	uint16_t acl_handle;
 	struct queue *io_queue;
+	GIOChannel *past_io;
 	unsigned int io_id[4];
 	uint8_t client_num;
 	int step;
@@ -712,6 +713,11 @@ static void test_post_teardown(const void *test_data)
 	if (data->io_queue)
 		queue_remove_all(data->io_queue, NULL, NULL, io_free);
 
+	if (data->past_io) {
+		g_io_channel_unref(data->past_io);
+		data->past_io = NULL;
+	}
+
 	/* Remove the watches with the test, as the sockets they keep open
 	 * hang up once the controller is removed, which would wake up the
 	 * main loop over and over for the following tests.
@@ -1716,6 +1722,8 @@ static void bthost_iso_disconnected(void *user_data)
 	data->handle = 0x0000;
 }
 
+static void iso_send(struct test_data *data, GIOChannel *io);
+
 static void iso_new_conn(uint16_t handle, void *user_data)
 {
 	struct test_data *data = user_data;
@@ -1727,6 +1735,12 @@ static void iso_new_conn(uint16_t handle, void *user_data)
 
 	data->handle = handle;
 
+	if (data->past_io) {
+		iso_send(data, data->past_io);
+		g_io_channel_unref(data->past_io);
+		data->past_io = NULL;
+	}
+
 	host = hciemu_client_get_host(data->hciemu);
 	bthost_add_iso_hook(host, data->handle, bthost_recv_data, data,
 				bthost_iso_disconnected);
@@ -2703,11 +2717,16 @@ static gboolean iso_pollout(GIOChannel *io, GIOCondition cond,
 	const struct iso_client_data *isodata = data->test_data;
 	unsigned int count;
 
-	if (isodata->past && !data->handle)
-		return TRUE;
-
 	data->io_id[0] = 0;
 
+	/* Send once the connection to the PAST receiver is there, see
+	 * iso_new_conn(), rather than waking up for good until then.
+	 */
+	if (isodata->past && !data->handle) {
+		data->past_io = g_io_channel_ref(io);
+		return FALSE;
+	}
+
 	tester_print("POLLOUT event received");
 
 	for (count = 0; count < isodata->repeat_send_pre_ts; ++count)
-- 
2.56.0