Crash in android/hal-sco.c

Crash in android/hal-sco.c

[Prabhu Chawandi]

Hi,

  I was trying to do SCO read using haltest but I was getting FPERROR.

So further I went debug coredump


static ssize_t in_read(struct audio_stream_in *stream, void *buffer,
                                                                size_t bytes)
{
        struct sco_stream_in *in = (struct sco_stream_in *) stream;
#if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
        size_t frame_size = audio_stream_in_frame_size(&in->stream);
#else
        size_t frame_size = audio_stream_frame_size(&stream->common);
#endif

        size_t frame_num = bytes / frame_size; ===> Floating point error.

        size_t input_frame_num = frame_num;


I am getting channel number as 1  from audio_channel_count_from_in_mask

which is reserved for future hence I am getting zero as return which
leading to the crash

manyThanks,
Prabhu

Re: Crash in android/hal-sco.c

[Szymon Janc]

Hi,

On Tuesday 31 of March 2015 18:43:16 Prabhu Chawandi wrote:
> Hi,
> 
>   I was trying to do SCO read using haltest but I was getting FPERROR.
> 
> So further I went debug coredump
> 
> 
> static ssize_t in_read(struct audio_stream_in *stream, void *buffer,
>                                                                 size_t
> bytes) {
>         struct sco_stream_in *in = (struct sco_stream_in *) stream;
> #if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
>         size_t frame_size = audio_stream_in_frame_size(&in->stream);
> #else
>         size_t frame_size = audio_stream_frame_size(&stream->common);
> #endif
> 
>         size_t frame_num = bytes / frame_size; ===> Floating point error.
> 
>         size_t input_frame_num = frame_num;
> 
> 
> I am getting channel number as 1  from audio_channel_count_from_in_mask
> 
> which is reserved for future hence I am getting zero as return which
> leading to the crash

Thanks for reporting.
I've just send a patch "android/hal-sco: Fix divide by zero". This should fix 
the crash so please test.

-- 
BR
Szymon Janc

Re: Crash in android/hal-sco.c

[Prabhu Chawandi]

Hi,

  Thank you for the patch. I am getting channel number as 1 for input
stream and 2 for output stream, but in the code I am seeing channel
Zero is valid, comment says for compatibility.

Any ways I can force the channel to be Zero in my case ??

manyThanks,
Prabhu

On Tue, Mar 31, 2015 at 8:36 PM, Szymon Janc <szymon.janc@tieto.com> wrote:
> Hi,
>
> On Tuesday 31 of March 2015 18:43:16 Prabhu Chawandi wrote:
>> Hi,
>>
>>   I was trying to do SCO read using haltest but I was getting FPERROR.
>>
>> So further I went debug coredump
>>
>>
>> static ssize_t in_read(struct audio_stream_in *stream, void *buffer,
>>                                                                 size_t
>> bytes) {
>>         struct sco_stream_in *in = (struct sco_stream_in *) stream;
>> #if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
>>         size_t frame_size = audio_stream_in_frame_size(&in->stream);
>> #else
>>         size_t frame_size = audio_stream_frame_size(&stream->common);
>> #endif
>>
>>         size_t frame_num = bytes / frame_size; ===> Floating point error.
>>
>>         size_t input_frame_num = frame_num;
>>
>>
>> I am getting channel number as 1  from audio_channel_count_from_in_mask
>>
>> which is reserved for future hence I am getting zero as return which
>> leading to the crash
>
> Thanks for reporting.
> I've just send a patch "android/hal-sco: Fix divide by zero". This should fix
> the crash so please test.
>
> --
> BR
> Szymon Janc