[PATCH BlueZ] sixaxis: DS4: use 0x12 cmd to get device bdaddr

[PATCH BlueZ] sixaxis: DS4: use 0x12 cmd to get device bdaddr

[Marek Czerski]

This change is required for Esperanza EGG109k ps controller clone.
EGG109k looks like PS3 controller but presents itself to the system
as PS4 controller. It does not respond to 0x81 command.
Command 0x12 contains both the device mac address as well as
configured host mac address, so it can be used to query
both. Kernel driver also uses 0x12 command for that.
---
 plugins/sixaxis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 27bc09815..8e212ee71 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -111,12 +111,12 @@ static int sixaxis_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
 
 static int ds4_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
 {
-	uint8_t buf[7];
+	uint8_t buf[16];
 	int ret;
 
 	memset(buf, 0, sizeof(buf));
 
-	buf[0] = 0x81;
+	buf[0] = 0x12;
 
 	ret = ioctl(fd, HIDIOCGFEATURE(sizeof(buf)), buf);
 	if (ret < 0) {
-- 
2.43.0

RE: [BlueZ] sixaxis: DS4: use 0x12 cmd to get device bdaddr

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1077281

---Test result---

Test Summary:
CheckPatch                    PENDING   0.32 seconds
GitLint                       PENDING   0.35 seconds
BuildEll                      PASS      18.00 seconds
BluezMake                     PASS      649.51 seconds
MakeCheck                     PASS      18.00 seconds
MakeDistcheck                 PASS      224.08 seconds
CheckValgrind                 PASS      278.33 seconds
CheckSmatch                   PASS      312.65 seconds
bluezmakeextell               PASS      167.12 seconds
IncrementalBuild              PENDING   0.35 seconds
ScanBuild                     PASS      938.28 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



https://github.com/bluez/bluez/pull/2015/checks

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] sixaxis: DS4: use 0x12 cmd to get device bdaddr

[Bastien Nocera]

Hello Marek,

Some comments below.

On Sat, 2026-04-04 at 14:30 +0200, Marek Czerski wrote:
> This change is required for Esperanza EGG109k ps controller clone.

This should be what's mentioned in the commit subject:
sixaxis: Fix pairing Esperanza EGG109k controller

> EGG109k looks like PS3 controller but presents itself to the system
> as PS4 controller. It does not respond to 0x81 command.
> Command 0x12 contains both the device mac address as well as
> configured host mac address, so it can be used to query
> both. Kernel driver also uses 0x12 command for that.

You should name the kernel driver (it's "hid-playstation").

Note that despite what the hid-sony driver says, it's not a "Bluetooth
MAC address" or mac address, but a "Bluetooth address".

I would also include a link to an online store or product page for the
device, so folks know what it looks like.

> ---
>  plugins/sixaxis.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index 27bc09815..8e212ee71 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -111,12 +111,12 @@ static int sixaxis_get_device_bdaddr(int fd,
> bdaddr_t *bdaddr)
>  
>  static int ds4_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
>  {
> -	uint8_t buf[7];
> +	uint8_t buf[16];

This is a good opportunity to copy the constants from hid-playstation:
#define DS4_FEATURE_REPORT_PAIRING_INFO         0x12
#define DS4_FEATURE_REPORT_PAIRING_INFO_SIZE    16
and use those.

>  	int ret;
>  
>  	memset(buf, 0, sizeof(buf));
>  
> -	buf[0] = 0x81;
> +	buf[0] = 0x12;
>  
>  	ret = ioctl(fd, HIDIOCGFEATURE(sizeof(buf)), buf);
>  	if (ret < 0) {

[PATCH BlueZ v2] sixaxis: Fix pairing Esperanza EGG109k controller

[Marek Czerski]

This change is required for Esperanza EGG109k ps controller clone.
EGG109k looks like PS3 controller but presents itself to the system
as PS4 controller. It does not respond to 0x81 command.
Command 0x12 contains both the device bluetooth address as well as
configured host bluetooth address, so it can be used to query
both. Kernel driver hid-playstation also uses 0x12 command for that.

Manufacturer link:
https://esperanza.pl/esperanza-gamepad-bezprzewodowy-ps3-marine-czarny,176,1701.html
---
 plugins/sixaxis.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 27bc09815..a04a76d39 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -39,6 +39,9 @@
 #include "profiles/input/server.h"
 #include "profiles/input/sixaxis.h"
 
+#define DS4_FEATURE_REPORT_PAIRING_INFO		0x12
+#define DS4_FEATURE_REPORT_PAIRING_INFO_SIZE	16
+
 struct authentication_closure {
 	guint auth_id;
 	char *sysfs_path;
@@ -111,12 +114,12 @@ static int sixaxis_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
 
 static int ds4_get_device_bdaddr(int fd, bdaddr_t *bdaddr)
 {
-	uint8_t buf[7];
+	uint8_t buf[DS4_FEATURE_REPORT_PAIRING_INFO_SIZE];
 	int ret;
 
 	memset(buf, 0, sizeof(buf));
 
-	buf[0] = 0x81;
+	buf[0] = DS4_FEATURE_REPORT_PAIRING_INFO;
 
 	ret = ioctl(fd, HIDIOCGFEATURE(sizeof(buf)), buf);
 	if (ret < 0) {
@@ -163,12 +166,12 @@ static int sixaxis_get_central_bdaddr(int fd, bdaddr_t *bdaddr)
 
 static int ds4_get_central_bdaddr(int fd, bdaddr_t *bdaddr)
 {
-	uint8_t buf[16];
+	uint8_t buf[DS4_FEATURE_REPORT_PAIRING_INFO_SIZE];
 	int ret;
 
 	memset(buf, 0, sizeof(buf));
 
-	buf[0] = 0x12;
+	buf[0] = DS4_FEATURE_REPORT_PAIRING_INFO;
 
 	ret = ioctl(fd, HIDIOCGFEATURE(sizeof(buf)), buf);
 	if (ret < 0) {
-- 
2.43.0

RE: [BlueZ,v2] sixaxis: Fix pairing Esperanza EGG109k controller

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2421 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1084434

---Test result---

Test Summary:
CheckPatch                    FAIL      1.76 seconds
GitLint                       FAIL      4.05 seconds
BuildEll                      PASS      20.38 seconds
BluezMake                     PASS      655.42 seconds
CheckSmatch                   PASS      347.82 seconds
bluezmakeextell               PASS      179.48 seconds
IncrementalBuild              PASS      647.34 seconds
ScanBuild                     PASS      1012.64 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2] sixaxis: Fix pairing Esperanza EGG109k controller
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#107: 
https://esperanza.pl/esperanza-gamepad-bezprzewodowy-ps3-marine-czarny,176,1701.html

/github/workspace/src/patch/14534484.patch total: 0 errors, 1 warnings, 37 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/patch/14534484.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2] sixaxis: Fix pairing Esperanza EGG109k controller

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
11: B1 Line exceeds max length (84>80): "https://esperanza.pl/esperanza-gamepad-bezprzewodowy-ps3-marine-czarny,176,1701.html"


https://github.com/bluez/bluez/pull/2063

---
Regards,
Linux Bluetooth