* [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names [not found] <20260506230051.27436-1-thomaskirschner85.ref@yahoo.de> @ 2026-05-06 23:00 ` Thomas Kirschner 2026-05-07 0:58 ` [BlueZ] " bluez.test.bot ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Thomas Kirschner @ 2026-05-06 23:00 UTC (permalink / raw) To: linux-bluetooth; +Cc: Thomas Kirschner MinimumDelay and PreferredMinimumDelay had wrong spelling, causing them to be exposed incorrectly over D-Bus. Any client relying on the correct spelling would fail to find these entries, breaking LE Audio QoS negotiation. --- profiles/audio/bap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c index 5333267f7..b35542488 100644 --- a/profiles/audio/bap.c +++ b/profiles/audio/bap.c @@ -432,11 +432,11 @@ static gboolean get_qos(const GDBusPropertyTable *property, dict_append_entry(&dict, "Retransmissions", DBUS_TYPE_BYTE, &qos->rtn); dict_append_entry(&dict, "MaximumLatency", DBUS_TYPE_UINT16, &qos->latency); - dict_append_entry(&dict, "MimimumDelay", DBUS_TYPE_UINT32, + dict_append_entry(&dict, "MinimumDelay", DBUS_TYPE_UINT32, &qos->pd_min); dict_append_entry(&dict, "MaximumDelay", DBUS_TYPE_UINT32, &qos->pd_max); - dict_append_entry(&dict, "PreferredMimimumDelay", DBUS_TYPE_UINT32, + dict_append_entry(&dict, "PreferredMinimumDelay", DBUS_TYPE_UINT32, &qos->ppd_min); dict_append_entry(&dict, "PreferredMaximumDelay", DBUS_TYPE_UINT32, &qos->ppd_max); -- 2.51.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names 2026-05-06 23:00 ` [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names Thomas Kirschner @ 2026-05-07 0:58 ` bluez.test.bot 2026-05-07 8:13 ` [PATCH BlueZ] " Bastien Nocera 2026-05-07 17:50 ` patchwork-bot+bluetooth 2 siblings, 0 replies; 4+ messages in thread From: bluez.test.bot @ 2026-05-07 0:58 UTC (permalink / raw) To: linux-bluetooth, thomaskirschner85 [-- Attachment #1: Type: text/plain, Size: 989 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1090721 ---Test result--- Test Summary: CheckPatch PASS 0.28 seconds GitLint PASS 0.20 seconds BuildEll PASS 19.93 seconds BluezMake PASS 664.48 seconds MakeCheck PASS 3.73 seconds MakeDistcheck PASS 242.46 seconds CheckValgrind PASS 224.20 seconds CheckSmatch PASS 345.16 seconds bluezmakeextell PASS 180.63 seconds IncrementalBuild PASS 652.49 seconds ScanBuild PASS 1008.10 seconds https://github.com/bluez/bluez/pull/2105 --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names 2026-05-06 23:00 ` [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names Thomas Kirschner 2026-05-07 0:58 ` [BlueZ] " bluez.test.bot @ 2026-05-07 8:13 ` Bastien Nocera 2026-05-07 17:50 ` patchwork-bot+bluetooth 2 siblings, 0 replies; 4+ messages in thread From: Bastien Nocera @ 2026-05-07 8:13 UTC (permalink / raw) To: Thomas Kirschner, linux-bluetooth LGTM On Thu, 2026-05-07 at 01:00 +0200, Thomas Kirschner wrote: > MinimumDelay and PreferredMinimumDelay had wrong spelling, causing > them to be exposed incorrectly over D-Bus. Any client relying on > the correct spelling would fail to find these entries, breaking > LE Audio QoS negotiation. > --- > profiles/audio/bap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c > index 5333267f7..b35542488 100644 > --- a/profiles/audio/bap.c > +++ b/profiles/audio/bap.c > @@ -432,11 +432,11 @@ static gboolean get_qos(const > GDBusPropertyTable *property, > dict_append_entry(&dict, "Retransmissions", DBUS_TYPE_BYTE, > &qos->rtn); > dict_append_entry(&dict, "MaximumLatency", DBUS_TYPE_UINT16, > &qos->latency); > - dict_append_entry(&dict, "MimimumDelay", DBUS_TYPE_UINT32, > + dict_append_entry(&dict, "MinimumDelay", DBUS_TYPE_UINT32, > &qos->pd_min); > dict_append_entry(&dict, "MaximumDelay", DBUS_TYPE_UINT32, > &qos->pd_max); > - dict_append_entry(&dict, "PreferredMimimumDelay", > DBUS_TYPE_UINT32, > + dict_append_entry(&dict, "PreferredMinimumDelay", > DBUS_TYPE_UINT32, > &qos->ppd_min); > dict_append_entry(&dict, "PreferredMaximumDelay", > DBUS_TYPE_UINT32, > &qos->ppd_max); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names 2026-05-06 23:00 ` [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names Thomas Kirschner 2026-05-07 0:58 ` [BlueZ] " bluez.test.bot 2026-05-07 8:13 ` [PATCH BlueZ] " Bastien Nocera @ 2026-05-07 17:50 ` patchwork-bot+bluetooth 2 siblings, 0 replies; 4+ messages in thread From: patchwork-bot+bluetooth @ 2026-05-07 17:50 UTC (permalink / raw) To: Thomas Kirschner; +Cc: linux-bluetooth Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 7 May 2026 01:00:51 +0200 you wrote: > MinimumDelay and PreferredMinimumDelay had wrong spelling, causing > them to be exposed incorrectly over D-Bus. Any client relying on > the correct spelling would fail to find these entries, breaking > LE Audio QoS negotiation. > --- > profiles/audio/bap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d45fd43a1cc3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-07 17:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260506230051.27436-1-thomaskirschner85.ref@yahoo.de>
2026-05-06 23:00 ` [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names Thomas Kirschner
2026-05-07 0:58 ` [BlueZ] " bluez.test.bot
2026-05-07 8:13 ` [PATCH BlueZ] " Bastien Nocera
2026-05-07 17:50 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox