Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH BlueZ] advertising: Refresh only advertisements that depend on discoverable
@ 2026-11-22 10:31 Simon Mikuda
  2026-11-22 18:47 ` [BlueZ] " bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Mikuda @ 2026-11-22 10:31 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Simon Mikuda

A change of the discoverable setting sets every advertisement again,
although only a peripheral one without its own Flags depends on it.
Some controllers can disturb a running BIG when the advertising set
of its broadcast source is restarted (an NXP one skips every third BIG
event after it).

Steps to reproduce:
1. Start a broadcast source whose announcement is a registered
   advertisement (LEAdvertisingManager1, Type "broadcast").
2. bluetoothctl discoverable on
3. The advertising set of the broadcast is disabled and enabled again
   (btmon), under the BIG.

Fixes: 91d4b17160b8 ("advertising: Configure discoverable flag based on adapter settings")
Assisted-by: Claude:claude-opus-5-5
---
 src/advertising.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/advertising.c b/src/advertising.c
index b68ff28f5..d07068c6c 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -2180,6 +2180,10 @@ static void manager_refresh(void *data, void *user_data)
 {
 	struct btd_adv_client *client = data;
 
+	/* Only a peripheral without its own Flags depends on discoverable */
+	if (client->type != AD_TYPE_PERIPHERAL || bt_ad_has_flags(client->data))
+		return;
+
 	refresh_advertisement(client, NULL);
 }
 

base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [BlueZ] advertising: Refresh only advertisements that depend on discoverable
  2026-11-22 10:31 [PATCH BlueZ] advertising: Refresh only advertisements that depend on discoverable Simon Mikuda
@ 2026-11-22 18:47 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-11-22 18:47 UTC (permalink / raw)
  To: linux-bluetooth, simon.mikuda

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1218566/

---Test result---

Test Summary:
CheckPatch                    PASS      0.31 seconds
GitLint                       PASS      0.22 seconds
BuildEll                      PASS      20.39 seconds
BluezMake                     PASS      312.91 seconds
CheckSmatch                   WARNING   318.49 seconds
bluezmakeextell               PASS      100.52 seconds
TestFunctional                PASS      1233.40 seconds
IncrementalBuild              PASS      313.26 seconds
ScanBuild                     PASS      1196.06 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capabilitysrc/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capability


https://github.com/bluez/bluez/pull/2865

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-22 18:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 10:31 [PATCH BlueZ] advertising: Refresh only advertisements that depend on discoverable Simon Mikuda
2026-11-22 18:47 ` [BlueZ] " bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox