Re: [PATCH 02/16] btrfs: move larger compat flag helpers to their own c file

[Anand Jain <anand.jain@oracle.com>]

On 16/09/2022 19:11, Anand Jain wrote:
> 
>> +void __btrfs_set_fs_compat_ro(struct btrfs_fs_info *fs_info, u64 flag,
>> +                  const char *name);
>> +void __btrfs_set_fs_compat_ro(struct btrfs_fs_info *fs_info, u64 flag,
>> +                  const char *name);
> 
>   There is an extra definition here.
>   I think David can take care of it while merging.

  With the above fixed. You may add

  Reviewed-by: Anand Jain <anand.jain@oracle.com>


>   While here, I would prefer to have functions arranged.
>   Like, first, set-function and then its related clear-function;
>   it improves readability.
> 
>>   #define btrfs_set_fs_incompat(__fs_info, opt) \
>>       __btrfs_set_fs_incompat((__fs_info), 
>> BTRFS_FEATURE_INCOMPAT_##opt, \
>>                   #opt)
> 
>   Further, the #defines are in the middle of the function definitions.
>   I suggest they be at the bottom of the file.
> 
> Thanks,
> Anand