Re: [PATCH 00/16] btrfs: split out larger chunks of ctree.h

[David Sterba <dsterba@suse.cz>]

On Wed, Sep 14, 2022 at 01:18:05PM -0400, Josef Bacik wrote:
> Hello,
> 
> This series is based on the series
> 
>   btrfs: initial ctree.h cleanups, simple stuff
> 
> which needs to be in place before applying these patches.
> 
> This is likely going to have the largest patch of the series, which bulk moves
> all of the struct funcs defines out of ctree.h into their own file.  This isn't
> really possible to do piecemeal like other changes because we're using macros
> instead of functions.  However the code is well organized so it allows for a
> bulk copy and paste, so is straightforward.
> 
> I've done my best with naming, but I'm open to suggestions.  My general plan is
> to have all fs wide definitions in fs.h, and then separate out individual things
> to their own headers.

The fs.h feels like another ctree.h but we have to start somewhere and
further moving stuff from fs.h sounds like a plan.
> 
> The biggest things I've done in this series are
> 
> 1. Move the printk helpers into their own files.
> 2. Move the main state flags and core fs helpers into their own files.
> 3. Moved the struct func definitions to their own files.
> 
> This is by no means complete, this is just the first big pass, but as you can
> see is already 17 patches long.  Subsequent patches will move more code and do
> more cleanups.  Thanks,

I'll try to merge such straightforward patchsets without much delay as
long as the changes are straightforward and reasonable assuming that
we'll reach perfection eventually. This series can be used as reference
for what is OK, with some minor fixups or renames. The name of
btrfs-printk.h stands out as it's using two subsystems while I'd expect
something more decriptive of what's inside like messages.h. For that a
resend is not necessary, just that we agree that a rename is fine.