Re: [PATCH 16/16] btrfs: move accessor helpers into item-accessors.h

[Anand Jain <anand.jain@oracle.com>]

On 15/09/2022 01:18, Josef Bacik wrote:
> This is a large patch, but because they're all macros it's impossible to
> split up.  Simply copy all of the item accessors in ctree.h and paste
> them in item-accessors.h, and then update any files to include the
> header so everything compiles.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Josef,

I hope the patch series dependency is correct, which I understand as below:

------------
[PATCH 00/17] btrfs: initial ctree.h cleanups, simple stuff
[PATCH 00/16] btrfs: split out larger chunks of ctree.h
[PATCH 00/15] btrfs: strip out btrfs_fs_info dependencies
[PATCH 00/10] btrfs: clean up zoned device helpers
------------

However, this patch compilation errors out:

-------------
/Volumes/ws/btrfs-devel/fs/btrfs/locking.c:98:52: error: implicit 
declaration of function ‘btrfs_header_level’; did you mean 
‘btrfs_qgroup_level’? [-Werror=implicit-function-declaration]
    98 |                                                eb, 
btrfs_header_level(eb));
       | 
^~~~~~~~~~~~~~~~~~
       |
-------------


It can be fixed by the below diff:

--------------
diff --git a/fs/btrfs/locking.c b/fs/btrfs/locking.c
index 9063072b399b..aa7aec25672a 100644
--- a/fs/btrfs/locking.c
+++ b/fs/btrfs/locking.c
@@ -12,6 +12,7 @@
  #include "ctree.h"
  #include "extent_io.h"
  #include "locking.h"
+#include "item-accessors.h"

  /*
   * Lockdep class keys for extent_buffer->lock's in this root.  For a given
-------------

Thanks, Anand