[PATCH] Fix possible pointer dereference

[PATCH] Fix possible pointer dereference

[Diego Calleja]

We should always check btrfs_alloc_path(). Some places BUG(),
others return -ENOMEM, btrfs_insert_dir_item() seems like it can return
safely.

Signed-off-by: Diego Calleja <diegocg@gmail.com>

--- linux/fs/btrfs/dir-item.c.BAK	2009-10-06 19:00:48.887361896 +0200
+++ linux/fs/btrfs/dir-item.c	2009-10-06 19:01:00.329132291 +0200
@@ -147,6 +147,9 @@ int btrfs_insert_dir_item(struct btrfs_t
 	key.offset = btrfs_name_hash(name, name_len);
 
 	path = btrfs_alloc_path();
+	if (!path)
+		return -ENOMEM;
+
 	path->leave_spinning = 1;
 
 	data_size = sizeof(*dir_item) + name_len;

Re: [PATCH] Fix possible pointer dereference

[Andi Kleen]

Diego Calleja <diegocg@gmail.com> writes:

> We should always check btrfs_alloc_path(). Some places BUG(),
> others return -ENOMEM, btrfs_insert_dir_item() seems like it can return
> safely.

The problem is that all the callers don't handle errors.
It doesn't make sense to fix it low-level currently when it cannot be handled
properly higher up anyways.

Proper out of memory handling needs much more work, one liners
don't really help.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.