Re: snapshot/subvolume removal

[Adrian von Bidder <avbidder@fortytwo.ch>]

[-- Attachment #1: Type: Text/Plain, Size: 941 bytes --]

On Wednesday 06 January 2010 01.30:35 TARUISI Hiroaki wrote:
> In creating snapshots, the last argument implies the directory
> where subvolume is to be created, but in taking snapshots,
> the last argument implies subvolume we take snapshot of, and
> snapshots are created under current directory.
> 

This was a bit confusing to me at first, too.  (But obviously '-s' needs the 
input which volume to take the snapshot from.)

Would it be a good idea to make btrfsctl -s fail if the last argument is not 
the root of a subvolume?  That way, the directory given to "btrfsctl -s" 
would always match what ends up in a snapshot.  (It is a bit strange for 
people who are not familiar with btrfs to do "btrfsctl -s snap 
some/directory/somewhere" and then realize that the snapshot is created from 
"some" and not from "somewhere" because "some" is the subvolume root.)

cheers
-- vbi

-- 
Pushing 40 is exercise enough.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 389 bytes --]