Re: snapshot/subvolume removal

[TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>]

Thanks for reply and changing.

I planned one more patch to list up all subvolumes
under fs tree. This must be useful in case of
mounting with subvol parameter.

Regards,
taruisi

(2010/01/11 5:18), Chris Mason wrote:
> On Fri, Jan 08, 2010 at 05:28:42PM +0900, TARUISI Hiroaki wrote:
>> For now, subvolumes and snapshots look like just directories.
>> If you want to distinguish them, there's only an unusual way,
>> that is, analyzing with btrfs-debug-tree.
>>
>> I posted patches for listing snapshots/subvolumes two months ago,
>> and Josef Bacik posted its bugfix patch. This feature may be
>> delivered in sooner or later.
>> If you want to try it now, check these URLs.
>>   http://patchwork.kernel.org/patch/60923/raw/
>>   http://patchwork.kernel.org/patch/60920/raw/
>>   http://patchwork.kernel.org/patch/67332/raw/
>> Patches and requests are welcome.
> 
> Thanks again for the subvolume listing patch, it's going to be a great
> feature.
> 
> I'm afraid I've had to make some small changes.  ioctls have
> some very strict rules for the arguments, and pointers and list heads
> should not be passed in ioctl structs.
> 
> We also need to change the patch to make the ioct args struct the same
> size on both 32 bit and 64 bit machines, which usually just means
> aligning and padding the fields as required.
> 
> I have started on this and hope to finish it on Tuesday.  But if you
> have any additions to the patch please let me know.
> 
> -chris