From: Chris Mason <chris.mason@oracle.com>
To: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
Cc: piavka@cs.bgu.ac.il, linux-btrfs@vger.kernel.org
Subject: Re: snapshot/subvolume removal
Date: Sun, 10 Jan 2010 15:18:12 -0500 [thread overview]
Message-ID: <20100110201812.GB32195@think> (raw)
In-Reply-To: <4B46ECBA.2030402@jp.fujitsu.com>
On Fri, Jan 08, 2010 at 05:28:42PM +0900, TARUISI Hiroaki wrote:
> For now, subvolumes and snapshots look like just directories.
> If you want to distinguish them, there's only an unusual way,
> that is, analyzing with btrfs-debug-tree.
>
> I posted patches for listing snapshots/subvolumes two months ago,
> and Josef Bacik posted its bugfix patch. This feature may be
> delivered in sooner or later.
> If you want to try it now, check these URLs.
> http://patchwork.kernel.org/patch/60923/raw/
> http://patchwork.kernel.org/patch/60920/raw/
> http://patchwork.kernel.org/patch/67332/raw/
> Patches and requests are welcome.
Thanks again for the subvolume listing patch, it's going to be a great
feature.
I'm afraid I've had to make some small changes. ioctls have
some very strict rules for the arguments, and pointers and list heads
should not be passed in ioctl structs.
We also need to change the patch to make the ioct args struct the same
size on both 32 bit and 64 bit machines, which usually just means
aligning and padding the fields as required.
I have started on this and hope to finish it on Tuesday. But if you
have any additions to the patch please let me know.
-chris
next prev parent reply other threads:[~2010-01-10 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 21:18 snapshot/subvolume removal Piavlo
2010-01-06 0:30 ` TARUISI Hiroaki
2010-01-06 6:54 ` Adrian von Bidder
2010-01-06 8:33 ` Piavlo
2010-01-08 8:28 ` TARUISI Hiroaki
2010-01-09 22:01 ` Piavlo
2010-01-12 0:48 ` TARUISI Hiroaki
2010-01-12 7:08 ` Piavlo
2010-01-12 8:04 ` TARUISI Hiroaki
2010-01-12 9:12 ` Adrian von Bidder
2010-01-12 11:03 ` Piavlo
2010-01-10 20:18 ` Chris Mason [this message]
2010-01-12 1:12 ` TARUISI Hiroaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110201812.GB32195@think \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=piavka@cs.bgu.ac.il \
--cc=taruishi.hiroak@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox