From: David Sterba <dsterba@suse.cz>
To: Marcos Paulo de Souza <marcos@mpdesouza.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] progs: Remove manpages of not packaged binaries
Date: Mon, 2 Mar 2020 21:02:31 +0100 [thread overview]
Message-ID: <20200302200231.GU2902@twin.jikos.cz> (raw)
In-Reply-To: <7a2549f38537c5a0f9262ae5e7aefd82e8464fb0.camel@mpdesouza.com>
On Sun, Mar 01, 2020 at 11:28:55AM -0300, Marcos Paulo de Souza wrote:
> On Sun, 2020-03-01 at 16:26 +0800, Qu Wenruo wrote:
> >
> > On 2020/3/1 上午11:33, Marcos Paulo de Souza wrote:
> > > From: Marcos Paulo de Souza <mpdesouza@suse.com>
> > >
> > > btrfs-find-root and btrfs-select-super stopped to be shipped in
> > 2014, so
> > > remove all references to these manpages as well.
> >
> > Nope, my distro is still shipping it, and I find it kinda useful for
> > certain recovery scenario.
> >
> > Thus it's better to keep their documents.
>
> Thanks for checking this Qu. What do you think about the other two
> patches?
>
> David, do you think you can only patches 2 and 3? The first patch can
> be skipped, since only the later two solve the issue.
I was not expecing to see actual removal of the manual pages but rather
removing manual pages installed by distro packages without the related
binaries. In the long term we want to migrate the functionality of
find-root and select-super to the 'rescue' subcommand and at that time
the manual pages' text will be moved. Until then it should be kept but
it's up to the distro package to either ship the binaries + manual pages
or neither.
next prev parent reply other threads:[~2020-03-02 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 3:33 [PATCH 0/3] progs: fix testsuite Marcos Paulo de Souza
2020-03-01 3:33 ` [PATCH 1/3] progs: Remove manpages of not packaged binaries Marcos Paulo de Souza
2020-03-01 8:26 ` Qu Wenruo
2020-03-01 14:28 ` Marcos Paulo de Souza
2020-03-02 20:02 ` David Sterba [this message]
2020-03-01 3:33 ` [PATCH 2/3] progs: Include btrfs-find-root and btrfs-select-super in testsuite Marcos Paulo de Souza
2020-03-02 0:02 ` Qu Wenruo
2020-03-01 3:33 ` [PATCH 3/3] progs: tests: misc: btrfs-{find-root,select-super} are internal commands Marcos Paulo de Souza
2020-03-02 0:03 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302200231.GU2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos@mpdesouza.com \
--cc=mpdesouza@suse.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox