Re: [PATCH 2/3] progs: Include btrfs-find-root and btrfs-select-super in testsuite

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1397 bytes --]



On 2020/3/1 上午11:33, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> Since these two binaries are not shipped into userspace, and they are
> used by the testsuite, they need to be include in the final tar.
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>

Just a small nitpick, the prefix for the patch should be "btrfs-progs: "
not "progs: ".

Thanks,
Qu
> ---
>  Makefile              | 2 +-
>  tests/testsuite-files | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index b00eafe4..0cd7f0c1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -424,7 +424,7 @@ test-inst: all
>  
>  test: test-fsck test-mkfs test-misc test-cli test-convert test-fuzz
>  
> -testsuite: btrfs-corrupt-block fssum
> +testsuite: btrfs-corrupt-block btrfs-find-root btrfs-select-super fssum
>  	@echo "Export tests as a package"
>  	$(Q)cd tests && ./export-testsuite.sh
>  
> diff --git a/tests/testsuite-files b/tests/testsuite-files
> index 09df6298..507d35fb 100644
> --- a/tests/testsuite-files
> +++ b/tests/testsuite-files
> @@ -3,6 +3,8 @@ G Documentation/
>  F testsuite-id
>  F ../fssum
>  F ../btrfs-corrupt-block
> +F ../btrfs-find-root
> +F ../btrfs-select-super
>  F common
>  F common.convert
>  F common.local
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]