* [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover
@ 2020-07-15 11:02 Nikolay Borisov
2020-07-15 13:38 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Borisov @ 2020-07-15 11:02 UTC (permalink / raw)
To: linux-btrfs; +Cc: Nikolay Borisov
There's no cleanup that occurs so we can simply return 0 directly.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/raid56.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index 61ff77392357..255490f42b5d 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -2083,7 +2083,7 @@ static int __raid56_parity_recover(struct btrfs_raid_bio *rbio)
*/
if (atomic_read(&rbio->error) <= rbio->bbio->max_errors) {
__raid_recover_end_io(rbio);
- goto out;
+ return 0;
} else {
goto cleanup;
}
@@ -2103,7 +2103,7 @@ static int __raid56_parity_recover(struct btrfs_raid_bio *rbio)
submit_bio(bio);
}
-out:
+
return 0;
cleanup:
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover
2020-07-15 11:02 [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover Nikolay Borisov
@ 2020-07-15 13:38 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-07-15 13:38 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: linux-btrfs
On Wed, Jul 15, 2020 at 02:02:17PM +0300, Nikolay Borisov wrote:
> There's no cleanup that occurs so we can simply return 0 directly.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Added to misc-next, thanks.
> @@ -2083,7 +2083,7 @@ static int __raid56_parity_recover(struct btrfs_raid_bio *rbio)
> */
> if (atomic_read(&rbio->error) <= rbio->bbio->max_errors) {
> __raid_recover_end_io(rbio);
> - goto out;
> + return 0;
The rest of the function can be seen from that point so readability is
not hurt.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-15 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-15 11:02 [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover Nikolay Borisov
2020-07-15 13:38 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox