public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling
Date: Wed, 29 Jul 2020 16:40:35 +0800	[thread overview]
Message-ID: <20200729084038.78151-1-wqu@suse.com> (raw)

This patchset is to address a bug report [1], where even with the bit
overflow bug fixed, the user is still unable to convert an ext4 fs to
btrfs.

The error is -ENOSPC, which triggers BUG_ON() and brings the end to the
convertion.

We're still waiting for the image dump to determine what's the real
cause is, but considering the user is still reporting around 40% free
space, I guess it's something wrong with the extent allocator.

But still, we can enhance btrfs-convert to make it handle errors more
gracefully, with better error message, and even some debugging info like
the available space / total space ratio.

Qu Wenruo (3):
  btrfs-progs: convert: handle errors better in ext2_copy_inodes()
  btrfs-progs: convert: update error message to reflect original fs
    unmodified cases
  btrfs-progs: convert: report available space before convertion happens

 convert/common.h      |  9 +++++++++
 convert/main.c        | 34 +++++++++++++++++++++++++++++++---
 convert/source-ext2.c | 42 +++++++++++++++++++++++++++++++-----------
 convert/source-fs.c   |  1 +
 4 files changed, 72 insertions(+), 14 deletions(-)

-- 
2.27.0


             reply	other threads:[~2020-07-29  8:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  8:40 Qu Wenruo [this message]
2020-07-29  8:40 ` [PATCH 1/3] btrfs-progs: convert: handle errors better in ext2_copy_inodes() Qu Wenruo
2020-07-29  8:40 ` [PATCH 2/3] btrfs-progs: convert: update error message to reflect original fs unmodified cases Qu Wenruo
2020-07-29  8:40 ` [PATCH 3/3] btrfs-progs: convert: report available space before convertion happens Qu Wenruo
2020-07-29  9:05   ` Su Yue
2020-07-29  9:13     ` Qu Wenruo
2020-07-31 15:35       ` David Sterba
2020-07-31 16:16 ` [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling David Sterba
2020-07-31 23:37   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729084038.78151-1-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox