From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Su Yue <Damenly_Su@gmx.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs-progs: convert: report available space before convertion happens
Date: Fri, 31 Jul 2020 17:35:54 +0200 [thread overview]
Message-ID: <20200731153554.GO3703@twin.jikos.cz> (raw)
In-Reply-To: <9904022e-8c16-bd93-960a-93f9019d19ba@gmx.com>
On Wed, Jul 29, 2020 at 05:13:14PM +0800, Qu Wenruo wrote:
> >> + cctx.free_bytes_initial * 100 / cctx.total_bytes);
> >> memset(&mkfs_cfg, 0, sizeof(mkfs_cfg)); mkfs_cfg.csum_type =
> >> csum_type; mkfs_cfg.label = cctx.volume_name;
> >> diff --git a/convert/source-fs.c b/convert/source-fs.c index
> >> f7fd3d6055b7..d2f7a825238d 100644 --- a/convert/source-fs.c +++
> >> b/convert/source-fs.c @@ -74,6 +74,7 @@ void
> >> init_convert_context(struct btrfs_convert_context *cctx)
> >> cache_tree_init(&cctx->used_space);
> >> cache_tree_init(&cctx->data_chunks);
> >> cache_tree_init(&cctx->free_space);
> >> + cache_tree_init(&cctx->free_space_initial);
> >> } void clean_convert_context(struct btrfs_convert_context
> >> *cctx)
> >
> > Did you forget the clean path? :)
>
> Oh, thanks for that!
> Just forgot that.
Which I assume means
--- a/convert/source-fs.c
+++ b/convert/source-fs.c
@@ -82,6 +82,7 @@ void clean_convert_context(struct btrfs_convert_context *cctx)
free_extent_cache_tree(&cctx->used_space);
free_extent_cache_tree(&cctx->data_chunks);
free_extent_cache_tree(&cctx->free_space);
+ free_extent_cache_tree(&cctx->free_space_initial);
}
int block_iterate_proc(u64 disk_block, u64 file_block,
next prev parent reply other threads:[~2020-07-31 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:40 [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling Qu Wenruo
2020-07-29 8:40 ` [PATCH 1/3] btrfs-progs: convert: handle errors better in ext2_copy_inodes() Qu Wenruo
2020-07-29 8:40 ` [PATCH 2/3] btrfs-progs: convert: update error message to reflect original fs unmodified cases Qu Wenruo
2020-07-29 8:40 ` [PATCH 3/3] btrfs-progs: convert: report available space before convertion happens Qu Wenruo
2020-07-29 9:05 ` Su Yue
2020-07-29 9:13 ` Qu Wenruo
2020-07-31 15:35 ` David Sterba [this message]
2020-07-31 16:16 ` [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling David Sterba
2020-07-31 23:37 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731153554.GO3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Damenly_Su@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox