From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling
Date: Fri, 31 Jul 2020 18:16:34 +0200 [thread overview]
Message-ID: <20200731161634.GP3703@twin.jikos.cz> (raw)
In-Reply-To: <20200729084038.78151-1-wqu@suse.com>
On Wed, Jul 29, 2020 at 04:40:35PM +0800, Qu Wenruo wrote:
> This patchset is to address a bug report [1], where even with the bit
> overflow bug fixed, the user is still unable to convert an ext4 fs to
> btrfs.
>
> The error is -ENOSPC, which triggers BUG_ON() and brings the end to the
> convertion.
>
> We're still waiting for the image dump to determine what's the real
> cause is, but considering the user is still reporting around 40% free
> space, I guess it's something wrong with the extent allocator.
>
> But still, we can enhance btrfs-convert to make it handle errors more
> gracefully, with better error message, and even some debugging info like
> the available space / total space ratio.
>
> Qu Wenruo (3):
> btrfs-progs: convert: handle errors better in ext2_copy_inodes()
> btrfs-progs: convert: update error message to reflect original fs
> unmodified cases
> btrfs-progs: convert: report available space before convertion happens
Added to devel, thanks. With the fixup and I've updated the space report
to look like this:
create btrfs filesystem:
blocksize: 4096
nodesize: 16384
features: extref, skinny-metadata (default)
checksum: crc32c
free space report:
total: 2147483648
free: 1610547200 (75.00%)
next prev parent reply other threads:[~2020-07-31 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:40 [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling Qu Wenruo
2020-07-29 8:40 ` [PATCH 1/3] btrfs-progs: convert: handle errors better in ext2_copy_inodes() Qu Wenruo
2020-07-29 8:40 ` [PATCH 2/3] btrfs-progs: convert: update error message to reflect original fs unmodified cases Qu Wenruo
2020-07-29 8:40 ` [PATCH 3/3] btrfs-progs: convert: report available space before convertion happens Qu Wenruo
2020-07-29 9:05 ` Su Yue
2020-07-29 9:13 ` Qu Wenruo
2020-07-31 15:35 ` David Sterba
2020-07-31 16:16 ` David Sterba [this message]
2020-07-31 23:37 ` [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731161634.GP3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox