public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anandsuveer@gmail.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] btrfs: init device stats for seed devices
Date: Mon, 21 Sep 2020 22:25:02 +0200	[thread overview]
Message-ID: <20200921202502.GT6756@twin.jikos.cz> (raw)
In-Reply-To: <8217721c-0bd9-67af-1900-9594689c127b@oracle.com>

On Sat, Sep 19, 2020 at 05:47:18AM +0800, Anand Jain wrote:
> 
> Seed read errors should remain persistent.

How? The seed device is read-only, we can't record the stats and
recording them on the sprout device has unclear meaning.

> A similar update to btrfs_run_dev_stats() is required?

  reply	other threads:[~2020-09-21 20:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 20:44 [PATCH 0/2][v2] Fix init for device stats for seed devices Josef Bacik
2020-09-18 20:44 ` [PATCH 1/2] btrfs: init " Josef Bacik
2020-09-18 21:47   ` Anand Jain
2020-09-21 20:25     ` David Sterba [this message]
2020-09-21 23:49       ` Anand Jain
2020-09-21 23:51   ` Anand Jain
2020-09-22 15:27   ` David Sterba
2020-09-22 17:12   ` David Sterba
2020-09-18 20:44 ` [PATCH 2/2] btrfs: return error if we're unable to read device stats Josef Bacik
2020-09-21 23:54   ` Anand Jain
2020-09-22 17:28   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921202502.GT6756@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anandsuveer@gmail.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox