From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] btrfs: init device stats for seed devices
Date: Tue, 22 Sep 2020 17:27:32 +0200 [thread overview]
Message-ID: <20200922152732.GF6756@twin.jikos.cz> (raw)
In-Reply-To: <b0c2be2e6722f091821521301f251628afcd8313.1600461724.git.josef@toxicpanda.com>
On Fri, Sep 18, 2020 at 04:44:32PM -0400, Josef Bacik wrote:
> We recently started recording device stats across the fleet, and noticed
> a large increase in messages such as this
>
> BTRFS warning (device dm-0): get dev_stats failed, not yet valid
>
> on our tiers that use seed devices for their root devices. This is
> because we do not initialize the device stats for any seed devices if we
> have a sprout device and mount using that sprout device. The basic
> steps for reproducing are
>
> mkfs seed device
> mount seed device
> fill seed device
> umount seed device
> btrfstune -S 1 seed device
> mount seed device
> btrfs device add -f sprout device /mnt/wherever
> umount /mnt/wherever
> mount sprout device /mnt/wherever
> btrfs device stats /mnt/wherever
Please turn that into a fstest.
next prev parent reply other threads:[~2020-09-22 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 20:44 [PATCH 0/2][v2] Fix init for device stats for seed devices Josef Bacik
2020-09-18 20:44 ` [PATCH 1/2] btrfs: init " Josef Bacik
2020-09-18 21:47 ` Anand Jain
2020-09-21 20:25 ` David Sterba
2020-09-21 23:49 ` Anand Jain
2020-09-21 23:51 ` Anand Jain
2020-09-22 15:27 ` David Sterba [this message]
2020-09-22 17:12 ` David Sterba
2020-09-18 20:44 ` [PATCH 2/2] btrfs: return error if we're unable to read device stats Josef Bacik
2020-09-21 23:54 ` Anand Jain
2020-09-22 17:28 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922152732.GF6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox