From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/2] btrfs: return error if we're unable to read device stats
Date: Tue, 22 Sep 2020 07:54:57 +0800 [thread overview]
Message-ID: <89f2e615-a7b8-3197-a4e4-205d52c9061b@oracle.com> (raw)
In-Reply-To: <6f50f5be859468da38bd504c0f78a97dbcd0306d.1600461724.git.josef@toxicpanda.com>
On 19/9/20 4:44 am, Josef Bacik wrote:
> I noticed when fixing device stats for seed devices that we simply threw
> away the return value from btrfs_search_slot(). This is because we may
> not have stat items, but we could very well get an error, and thus miss
> reporting the error up the chain. Fix this by returning ret if it's an
> actual error, and then stop trying to init the rest of the devices stats
> and return the error up the chain.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
next prev parent reply other threads:[~2020-09-21 23:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 20:44 [PATCH 0/2][v2] Fix init for device stats for seed devices Josef Bacik
2020-09-18 20:44 ` [PATCH 1/2] btrfs: init " Josef Bacik
2020-09-18 21:47 ` Anand Jain
2020-09-21 20:25 ` David Sterba
2020-09-21 23:49 ` Anand Jain
2020-09-21 23:51 ` Anand Jain
2020-09-22 15:27 ` David Sterba
2020-09-22 17:12 ` David Sterba
2020-09-18 20:44 ` [PATCH 2/2] btrfs: return error if we're unable to read device stats Josef Bacik
2020-09-21 23:54 ` Anand Jain [this message]
2020-09-22 17:28 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f2e615-a7b8-3197-a4e4-205d52c9061b@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox