* [PATCH] btrfs-progs: qgroup: remove outdated comment
@ 2021-03-22 14:03 Sidong Yang
2021-03-22 22:57 ` Qu Wenruo
2021-03-23 14:48 ` David Sterba
0 siblings, 2 replies; 4+ messages in thread
From: Sidong Yang @ 2021-03-22 14:03 UTC (permalink / raw)
To: linux-btrfs; +Cc: Sidong Yang
This comment is outdated and this patch remove
it to avoid confusion.
Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
cmds/qgroup.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/cmds/qgroup.c b/cmds/qgroup.c
index 2da83ffd..b33f77fa 100644
--- a/cmds/qgroup.c
+++ b/cmds/qgroup.c
@@ -81,9 +81,6 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,
path = argv[optind + 2];
- /*
- * FIXME src should accept subvol path
- */
if (btrfs_qgroup_level(args.src) >= btrfs_qgroup_level(args.dst)) {
error("bad relation requested: %s", path);
return 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: qgroup: remove outdated comment
2021-03-22 14:03 [PATCH] btrfs-progs: qgroup: remove outdated comment Sidong Yang
@ 2021-03-22 22:57 ` Qu Wenruo
2021-03-23 14:48 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: Qu Wenruo @ 2021-03-22 22:57 UTC (permalink / raw)
To: Sidong Yang, linux-btrfs
On 2021/3/22 下午10:03, Sidong Yang wrote:
> This comment is outdated and this patch remove
> it to avoid confusion.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> cmds/qgroup.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/cmds/qgroup.c b/cmds/qgroup.c
> index 2da83ffd..b33f77fa 100644
> --- a/cmds/qgroup.c
> +++ b/cmds/qgroup.c
> @@ -81,9 +81,6 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,
>
> path = argv[optind + 2];
>
> - /*
> - * FIXME src should accept subvol path
> - */
> if (btrfs_qgroup_level(args.src) >= btrfs_qgroup_level(args.dst)) {
> error("bad relation requested: %s", path);
> return 1;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: qgroup: remove outdated comment
2021-03-22 14:03 [PATCH] btrfs-progs: qgroup: remove outdated comment Sidong Yang
2021-03-22 22:57 ` Qu Wenruo
@ 2021-03-23 14:48 ` David Sterba
2021-03-23 15:43 ` Sidong Yang
1 sibling, 1 reply; 4+ messages in thread
From: David Sterba @ 2021-03-23 14:48 UTC (permalink / raw)
To: Sidong Yang; +Cc: linux-btrfs
On Mon, Mar 22, 2021 at 02:03:16PM +0000, Sidong Yang wrote:
> This comment is outdated and this patch remove
> it to avoid confusion.
Even if it's just a comment removal, changelog should say why it's
outated, I have no idea and would have to do the research myself.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: qgroup: remove outdated comment
2021-03-23 14:48 ` David Sterba
@ 2021-03-23 15:43 ` Sidong Yang
0 siblings, 0 replies; 4+ messages in thread
From: Sidong Yang @ 2021-03-23 15:43 UTC (permalink / raw)
To: dsterba, linux-btrfs
On Tue, Mar 23, 2021 at 03:48:16PM +0100, David Sterba wrote:
> On Mon, Mar 22, 2021 at 02:03:16PM +0000, Sidong Yang wrote:
> > This comment is outdated and this patch remove
> > it to avoid confusion.
>
> Even if it's just a comment removal, changelog should say why it's
> outated, I have no idea and would have to do the research myself.
Understood, Thanks for advice. I'll fix changelog for patch v2.
Thanks,
Sidong
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-23 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 14:03 [PATCH] btrfs-progs: qgroup: remove outdated comment Sidong Yang
2021-03-22 22:57 ` Qu Wenruo
2021-03-23 14:48 ` David Sterba
2021-03-23 15:43 ` Sidong Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox