From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: check: fix wrong total bytes check for seed device
Date: Tue, 19 Apr 2022 18:18:19 +0200 [thread overview]
Message-ID: <20220419161819.GF2348@twin.jikos.cz> (raw)
In-Reply-To: <8ed9c80d960090f44b11c4420b5bfbe04170c4a4.1650180472.git.wqu@suse.com>
On Sun, Apr 17, 2022 at 03:30:35PM +0800, Qu Wenruo wrote:
> @@ -8579,7 +8583,9 @@ static bool is_super_size_valid(void)
> if (!IS_ALIGNED(super_bytes, gfs_info->sectorsize) ||
> !IS_ALIGNED(total_bytes, gfs_info->sectorsize) ||
> super_bytes != total_bytes) {
> - warning("minor unaligned/mismatch device size detected");
> + warning("minor unaligned/mismatch device size detected:");
> + warning(" super block total bytes=%llu found total bytes=%llu",
> + super_bytes, total_bytes);
Minor thing, the message in warning() should be split the string and
indent, not add another call, that's how it it is done now. If we decide
to do some kind of auto split or reformat then we can do it inside the
helper.
> warning(
> "recommended to use 'btrfs rescue fix-device-size' to fix it");
> }
> --
> 2.35.1
next prev parent reply other threads:[~2022-04-19 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 7:30 [PATCH 0/2] btrfs-progs: fsck: fix false warning on sprouted filesystems Qu Wenruo
2022-04-17 7:30 ` [PATCH 1/2] btrfs-progs: check: fix wrong total bytes check for seed device Qu Wenruo
2022-04-17 9:33 ` Su Yue
2022-04-19 16:18 ` David Sterba [this message]
2022-04-17 7:30 ` [PATCH 2/2] btrfs-progs: fsck-tests: check warning for seed and sprouted filesystems Qu Wenruo
2022-04-25 17:04 ` David Sterba
2022-04-25 22:44 ` Qu Wenruo
2022-04-25 22:42 ` David Sterba
2022-04-25 23:06 ` Qu Wenruo
2022-04-25 23:15 ` David Sterba
2022-04-25 17:06 ` [PATCH 0/2] btrfs-progs: fsck: fix false warning on " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419161819.GF2348@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox