Re: [PATCH 2/2] btrfs-progs: fsck-tests: check warning for seed and sprouted filesystems

[David Sterba <dsterba@suse.cz>]

On Sun, Apr 17, 2022 at 03:30:36PM +0800, Qu Wenruo wrote:
> Previously we had a bug that btrfs check would report false warning for
> a sprouted filesystem.
> 
> So this patch will add a new test case to make sure neither seed nor
> and sprouted filesystem will cause such false warning.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  .../fsck-tests/057-seed-false-alerts/test.sh  | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100755 tests/fsck-tests/057-seed-false-alerts/test.sh
> 
> diff --git a/tests/fsck-tests/057-seed-false-alerts/test.sh b/tests/fsck-tests/057-seed-false-alerts/test.sh
> new file mode 100755
> index 000000000000..3a442c1202d0
> --- /dev/null
> +++ b/tests/fsck-tests/057-seed-false-alerts/test.sh
> @@ -0,0 +1,51 @@
> +#!/bin/bash
> +#
> +# Make sure "btrfs check" won't report false alerts on sprouted filesystems
> +#
> +
> +source "$TEST_TOP/common"
> +
> +check_prereq btrfs
> +check_prereq mkfs.btrfs
> +check_prereq btrfstune
> +check_global_prereq losetup
> +
> +setup_loopdevs 2
> +prepare_loopdevs
> +dev1=${loopdevs[1]}
> +dev2=${loopdevs[2]}
> +TEST_DEV=$dev1
> +
> +setup_root_helper
> +
> +run_check $SUDO_HELPERS "$TOP/mkfs.btrfs" -f $dev1
             ^^^^^^^^^^^^^

It's $SUDO_HELPER, otherwise it does not work, also please quote all
shell variables, everywhere.

> +run_check $SUDO_HELPERS "$TOP/btrfstune" -S1 $dev1
> +run_check_mount_test_dev
> +run_check $SUDO_HELPERS "$TOP/btrfs" device add -f $dev2 $TEST_MNT
> +
> +# Here we can not use umount helper, as it uses the seed device to do the
> +# umount. We need to manually unmout using the mount point
> +run_check $SUDO_HELPERS umount $TEST_MNT
> +
> +seed_output=$(_mktemp --tmpdir btrfs-progs-seed-check-stdout.XXXXXX)

This won't work as intended, there's a helper _mktemp_dir that creates a
temporary directory, otherwise --tmpdir is interpreted as the direcotry
name.