From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: fsck-tests: check warning for seed and sprouted filesystems
Date: Tue, 26 Apr 2022 00:42:53 +0200 [thread overview]
Message-ID: <20220425224253.GU18596@twin.jikos.cz> (raw)
In-Reply-To: <57d6192b-e1fd-bd14-d869-d03559c34eb1@gmx.com>
On Tue, Apr 26, 2022 at 06:44:04AM +0800, Qu Wenruo wrote:
> > This won't work as intended, there's a helper _mktemp_dir that creates a
> > temporary directory, otherwise --tmpdir is interpreted as the direcotry
> > name.
>
> My bad, it should be mktemp without the "_" prefix, just like what we
> did in all the run* helpers.
>
> And I'm not expected to create a directory, thus I don't need to
> _mktemp_dir.
Right, I figured it later and dropped the _dir name and verified it
works.
next prev parent reply other threads:[~2022-04-25 22:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 7:30 [PATCH 0/2] btrfs-progs: fsck: fix false warning on sprouted filesystems Qu Wenruo
2022-04-17 7:30 ` [PATCH 1/2] btrfs-progs: check: fix wrong total bytes check for seed device Qu Wenruo
2022-04-17 9:33 ` Su Yue
2022-04-19 16:18 ` David Sterba
2022-04-17 7:30 ` [PATCH 2/2] btrfs-progs: fsck-tests: check warning for seed and sprouted filesystems Qu Wenruo
2022-04-25 17:04 ` David Sterba
2022-04-25 22:44 ` Qu Wenruo
2022-04-25 22:42 ` David Sterba [this message]
2022-04-25 23:06 ` Qu Wenruo
2022-04-25 23:15 ` David Sterba
2022-04-25 17:06 ` [PATCH 0/2] btrfs-progs: fsck: fix false warning on " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425224253.GU18596@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox