Re: [kbuild] Re: [PATCH 2/2] btrfs: Use btrfs_try_lock_balance in btrfs_ioctl_balance

[David Sterba <dsterba@suse.cz>]

On Wed, May 04, 2022 at 11:44:51AM +0300, Nikolay Borisov wrote:
> 
> 
> On 4.05.22 г. 9:46 ч., Dan Carpenter wrote:
> > Hi Nikolay,
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Nikolay-Borisov/Refactor-btrfs_ioctl_balance/20220503-163837
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git  for-next
> > config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220504/202205041423.NVVJIHSj-lkp@intel.com/config )
> > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > smatch warnings:
> > fs/btrfs/ioctl.c:4493 btrfs_ioctl_balance() error: double free of 'bargs'
> > 
> > vim +/bargs +4493 fs/btrfs/ioctl.c
> 
> 
> Yep, a genuine braino, the fix is to remove either of the calls. I 
> personally would go with the one before mnt_drop_write so that we drop 
> the write ASAP but in the end I doubt it makes any practical difference. 
> David care to fold this or shall I resend?

Please resend, thanks.