From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] btrfs: Use btrfs_try_lock_balance in btrfs_ioctl_balance
Date: Mon, 9 May 2022 21:51:04 +0200 [thread overview]
Message-ID: <20220509195104.GF18596@twin.jikos.cz> (raw)
In-Reply-To: <20220505070825.1218337-1-nborisov@suse.com>
On Thu, May 05, 2022 at 10:08:25AM +0300, Nikolay Borisov wrote:
> This eliminates 2 labels and makes the code generally more streamlined.
> Also rename the 'out_bargs' label to 'out_unlock' since bargs is going
> to be freed under the 'out' label. This also fixes a memory leak since
> bargs wasn't correctly freed in one of the condition which are now moved
> in btrfs_try_lock_balance.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>
> V2:
> * Removed extra call to kfree(bargs) which resulted in a double free
Where does this patch apply to? It's using btrfs_try_lock_balance but that
does not exist in code nor in the patch.
next prev parent reply other threads:[~2022-05-09 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 8:36 [PATCH 0/2] Refactor btrfs_ioctl_balance Nikolay Borisov
2022-05-03 8:36 ` [PATCH 1/2] btrfs: Introduce btrfs_try_lock_balance Nikolay Borisov
2022-05-03 10:20 ` kernel test robot
2022-05-03 8:36 ` [PATCH 2/2] btrfs: Use btrfs_try_lock_balance in btrfs_ioctl_balance Nikolay Borisov
2022-05-04 6:46 ` [kbuild] " Dan Carpenter
2022-05-04 8:44 ` Nikolay Borisov
2022-05-04 15:25 ` David Sterba
2022-05-05 7:08 ` [PATCH v2] " Nikolay Borisov
2022-05-09 19:51 ` David Sterba [this message]
2022-05-10 5:42 ` Nikolay Borisov
2022-05-27 15:58 ` David Sterba
2022-05-06 9:04 ` [btrfs] c696e46e6e: BUG:KASAN:double-free_or_invalid-free_in_btrfs_ioctl_balance kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509195104.GF18596@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox