public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2
Date: Tue, 6 Sep 2022 18:16:18 +0200	[thread overview]
Message-ID: <20220906161618.GR13489@twin.jikos.cz> (raw)
In-Reply-To: <20220823200106.GN13489@twin.jikos.cz>

On Tue, Aug 23, 2022 at 10:01:06PM +0200, David Sterba wrote:
> On Tue, Aug 09, 2022 at 01:02:15PM +0800, Qu Wenruo wrote:
> > [Changelog]
> > v3:
> > - Add artificial requirement on fst and no-holes
> >   This is to address the concern from Josef on too many feature
> >   combinations.
> >   In fact I believe future features should also have hard requirement
> >   on the latest default features.
> > 
> > v2:
> > - Rebased to latest misc-next
> >   This fixes some random crash not related to btrfs.
> > 
> > - Fix some missing conversion due to bad branch
> >   I got my code messed up due to some bad local branch naming.
> >   The previous version sent to the ML lacks some essential conversion.
> > 
> >   Now it can properly pass full fstest run with block group tree.
> > 
> > This is the kernel part to revive block-group-tree feature.
> > 
> > Thanfully unlike btrfs-progs, the changes to kernel is much smaller, and
> > we can re-use most of the infrastructures from the extent-tree-v2
> > preparation patches.
> > 
> > But there are still some changes needed:
> > 
> > - Enhance unsupporter compat RO flags handling
> >   Extent tree is only needed for read-write opeartions, and for
> >   unsupported compat RO flags, we should not do any write into the fs.
> > 
> >   So this patch will make the kernel to skip block group items search
> >   if there is any unsupport RO compat flags.
> > 
> >   And really make the incoming block-group-tree feature compat RO.
> > 
> >   Unfortunately, we need that patch to be backported, or older kernels
> >   will still reject RO mounts of fses with block-group-tree feature.
> > 
> > - Don't store block group root into super block
> >   There is no special reason for block group root to be stored in super
> >   block.
> >   We should review those preparation patches with more scrutiny.
> > 
> > 
> > For the proper time reduction introduced by this patchset, the old data
> > should still be correct, as the on-disk format is not changed.
> > https://lwn.net/Articles/801990/
> > 
> > 
> > Qu Wenruo (3):
> >   btrfs: enhance unsupported compat RO flags handling
> >   btrfs: don't save block group root into super block
> >   btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2
> 
> Adding this to for-next.

Moved to misc-next, thanks.

      reply	other threads:[~2022-09-06 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  5:02 [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2 Qu Wenruo
2022-08-09  5:02 ` [PATCH v3 1/3] btrfs: enhance unsupported compat RO flags handling Qu Wenruo
2022-09-05 14:53   ` David Sterba
2022-09-05 22:36     ` Qu Wenruo
2022-08-09  5:02 ` [PATCH v3 2/3] btrfs: don't save block group root into super block Qu Wenruo
2022-08-09  5:02 ` [PATCH v3 3/3] btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2 Qu Wenruo
2022-09-05 15:01   ` David Sterba
2022-09-05 22:37     ` Qu Wenruo
2022-09-06 16:15       ` David Sterba
2022-08-23 20:01 ` [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2 David Sterba
2022-09-06 16:16   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906161618.GR13489@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox