From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 3/3] btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2
Date: Tue, 6 Sep 2022 06:37:50 +0800 [thread overview]
Message-ID: <67b45a55-058e-55ca-9327-deb23e6ee7c0@gmx.com> (raw)
In-Reply-To: <20220905150127.GG13489@twin.jikos.cz>
On 2022/9/5 23:01, David Sterba wrote:
> On Tue, Aug 09, 2022 at 01:02:18PM +0800, Qu Wenruo wrote:
>> --- a/include/uapi/linux/btrfs.h
>> +++ b/include/uapi/linux/btrfs.h
>> @@ -290,6 +290,12 @@ struct btrfs_ioctl_fs_info_args {
>> #define BTRFS_FEATURE_COMPAT_RO_FREE_SPACE_TREE_VALID (1ULL << 1)
>> #define BTRFS_FEATURE_COMPAT_RO_VERITY (1ULL << 2)
>>
>> +/*
>> + * Put all block group items into a dedicate block group tree, greatly
>> + * reduce mount time for large fs.
>> + */
>> +#define BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE (1ULL << 5)
>
> Is there a reason to skip the bits 3 and 4? Ie. why isn't this (1 << 3) ?
I was saving 3 and 4 for EXTRA_SUPER_RESERVE (extra reserved space after
1MiB, needs a new member in super block) and WRITE_INTENT for raid56.
But obviously bg-tree is way easier to push, so would you mind to change
it (1<<3)?
Thanks,
Qu
next prev parent reply other threads:[~2022-09-05 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 5:02 [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2 Qu Wenruo
2022-08-09 5:02 ` [PATCH v3 1/3] btrfs: enhance unsupported compat RO flags handling Qu Wenruo
2022-09-05 14:53 ` David Sterba
2022-09-05 22:36 ` Qu Wenruo
2022-08-09 5:02 ` [PATCH v3 2/3] btrfs: don't save block group root into super block Qu Wenruo
2022-08-09 5:02 ` [PATCH v3 3/3] btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2 Qu Wenruo
2022-09-05 15:01 ` David Sterba
2022-09-05 22:37 ` Qu Wenruo [this message]
2022-09-06 16:15 ` David Sterba
2022-08-23 20:01 ` [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2 David Sterba
2022-09-06 16:16 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b45a55-058e-55ca-9327-deb23e6ee7c0@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox