From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2
Date: Tue, 9 Aug 2022 13:02:15 +0800 [thread overview]
Message-ID: <cover.1660021230.git.wqu@suse.com> (raw)
[Changelog]
v3:
- Add artificial requirement on fst and no-holes
This is to address the concern from Josef on too many feature
combinations.
In fact I believe future features should also have hard requirement
on the latest default features.
v2:
- Rebased to latest misc-next
This fixes some random crash not related to btrfs.
- Fix some missing conversion due to bad branch
I got my code messed up due to some bad local branch naming.
The previous version sent to the ML lacks some essential conversion.
Now it can properly pass full fstest run with block group tree.
This is the kernel part to revive block-group-tree feature.
Thanfully unlike btrfs-progs, the changes to kernel is much smaller, and
we can re-use most of the infrastructures from the extent-tree-v2
preparation patches.
But there are still some changes needed:
- Enhance unsupporter compat RO flags handling
Extent tree is only needed for read-write opeartions, and for
unsupported compat RO flags, we should not do any write into the fs.
So this patch will make the kernel to skip block group items search
if there is any unsupport RO compat flags.
And really make the incoming block-group-tree feature compat RO.
Unfortunately, we need that patch to be backported, or older kernels
will still reject RO mounts of fses with block-group-tree feature.
- Don't store block group root into super block
There is no special reason for block group root to be stored in super
block.
We should review those preparation patches with more scrutiny.
For the proper time reduction introduced by this patchset, the old data
should still be correct, as the on-disk format is not changed.
https://lwn.net/Articles/801990/
Qu Wenruo (3):
btrfs: enhance unsupported compat RO flags handling
btrfs: don't save block group root into super block
btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2
fs/btrfs/block-group.c | 11 ++++++-
fs/btrfs/block-rsv.c | 1 +
fs/btrfs/ctree.h | 30 +++----------------
fs/btrfs/disk-io.c | 59 +++++++++++++++++++-------------------
fs/btrfs/disk-io.h | 2 +-
fs/btrfs/super.c | 9 ++++++
fs/btrfs/sysfs.c | 2 ++
fs/btrfs/transaction.c | 8 ------
include/uapi/linux/btrfs.h | 6 ++++
9 files changed, 62 insertions(+), 66 deletions(-)
--
2.37.0
next reply other threads:[~2022-08-09 5:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 5:02 Qu Wenruo [this message]
2022-08-09 5:02 ` [PATCH v3 1/3] btrfs: enhance unsupported compat RO flags handling Qu Wenruo
2022-09-05 14:53 ` David Sterba
2022-09-05 22:36 ` Qu Wenruo
2022-08-09 5:02 ` [PATCH v3 2/3] btrfs: don't save block group root into super block Qu Wenruo
2022-08-09 5:02 ` [PATCH v3 3/3] btrfs: separate BLOCK_GROUP_TREE compat RO flag from EXTENT_TREE_V2 Qu Wenruo
2022-09-05 15:01 ` David Sterba
2022-09-05 22:37 ` Qu Wenruo
2022-09-06 16:15 ` David Sterba
2022-08-23 20:01 ` [PATCH v3 0/3] btrfs: separate BLOCK_GROUP_TREE feature from extent-tree-v2 David Sterba
2022-09-06 16:16 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1660021230.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox