Re: [PATCH] btrfs-progs: add CHANGING_FSID_V2 to print-tree

[David Sterba <dsterba@suse.cz>]

On Tue, May 30, 2023 at 06:15:11PM +0800, Anand Jain wrote:
> Add the DEF_SUPER_FLAG_ENTRY for CHANGING_FSID_V2 to our btrfs-progs'
> print-tree.c, as it is currently missing in the dump-super output, which
> was too confusing.
> 
> Before:
> flags			0x1000000001
> 			( WRITTEN )
> 
> After:
> flags			0x1000000001
> 			( WRITTEN |
> 			  CHANGING_FSID_V2 )
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  kernel-shared/print-tree.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c
> index aaaf58ae2e0f..623f192aaefc 100644
> --- a/kernel-shared/print-tree.c
> +++ b/kernel-shared/print-tree.c
> @@ -1721,6 +1721,7 @@ static struct readable_flag_entry super_flags_array[] = {
>  	DEF_HEADER_FLAG_ENTRY(WRITTEN),
>  	DEF_HEADER_FLAG_ENTRY(RELOC),
>  	DEF_SUPER_FLAG_ENTRY(CHANGING_FSID),
> +	DEF_SUPER_FLAG_ENTRY(CHANGING_FSID_V2),

Should the flag be also added to BTRFS_SUPER_FLAG_SUPP? Currently all
the other SUPER_FLAGs are there.

>  	DEF_SUPER_FLAG_ENTRY(SEEDING),
>  	DEF_SUPER_FLAG_ENTRY(METADUMP),
>  	DEF_SUPER_FLAG_ENTRY(METADUMP_V2)
> -- 
> 2.31.1