From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: add CHANGING_FSID_V2 to print-tree
Date: Wed, 31 May 2023 13:00:11 +0200 [thread overview]
Message-ID: <20230531110011.GF32581@suse.cz> (raw)
In-Reply-To: <feebdbb8-d7d8-c51a-6ed7-95f18def2827@oracle.com>
On Wed, May 31, 2023 at 01:46:31PM +0800, Anand Jain wrote:
> On 30/05/2023 20:37, David Sterba wrote:
> > On Tue, May 30, 2023 at 06:15:11PM +0800, Anand Jain wrote:
> >> Add the DEF_SUPER_FLAG_ENTRY for CHANGING_FSID_V2 to our btrfs-progs'
> >> print-tree.c, as it is currently missing in the dump-super output, which
> >> was too confusing.
> >>
> >> Before:
> >> flags 0x1000000001
> >> ( WRITTEN )
> >>
> >> After:
> >> flags 0x1000000001
> >> ( WRITTEN |
> >> CHANGING_FSID_V2 )
> >>
> >> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> >> ---
> >> kernel-shared/print-tree.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c
> >> index aaaf58ae2e0f..623f192aaefc 100644
> >> --- a/kernel-shared/print-tree.c
> >> +++ b/kernel-shared/print-tree.c
> >> @@ -1721,6 +1721,7 @@ static struct readable_flag_entry super_flags_array[] = {
> >> DEF_HEADER_FLAG_ENTRY(WRITTEN),
> >> DEF_HEADER_FLAG_ENTRY(RELOC),
> >> DEF_SUPER_FLAG_ENTRY(CHANGING_FSID),
> >> + DEF_SUPER_FLAG_ENTRY(CHANGING_FSID_V2),
> >
> > Should the flag be also added to BTRFS_SUPER_FLAG_SUPP? Currently all
> > the other SUPER_FLAGs are there.
>
> I have the patch locally and need to confirm a few things before sending
> it, which can be a separate patch.
OK, so this one was added to devel, thanks.
next prev parent reply other threads:[~2023-05-31 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 10:15 [PATCH] btrfs-progs: add CHANGING_FSID_V2 to print-tree Anand Jain
2023-05-30 12:37 ` David Sterba
2023-05-31 5:46 ` Anand Jain
2023-05-31 11:00 ` David Sterba [this message]
2023-05-31 0:01 ` Qu Wenruo
2023-05-31 2:08 ` Qu Wenruo
2023-05-31 7:56 ` Anand Jain
2023-05-31 8:06 ` [PATCH v2] " Anand Jain
2023-05-31 8:15 ` Qu Wenruo
2023-05-31 23:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531110011.GF32581@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox