Re: [PATCH] btrfs-progs: add CHANGING_FSID_V2 to print-tree

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2023/5/31 08:01, Qu Wenruo wrote:
>
>
> On 2023/5/30 18:15, Anand Jain wrote:
>> Add the DEF_SUPER_FLAG_ENTRY for CHANGING_FSID_V2 to our btrfs-progs'
>> print-tree.c, as it is currently missing in the dump-super output, which
>> was too confusing.
>>
>> Before:
>> flags            0x1000000001
>>             ( WRITTEN )

But my concern is, why we didn't show something like " | Unknown flags
..." in the first place?

Isn't this a bug already?

Thanks,
Qu
>>
>> After:
>> flags            0x1000000001
>>             ( WRITTEN |
>>               CHANGING_FSID_V2 )
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> The patch itself looks fine.
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> Thanks,
> Qu
>> ---
>>   kernel-shared/print-tree.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c
>> index aaaf58ae2e0f..623f192aaefc 100644
>> --- a/kernel-shared/print-tree.c
>> +++ b/kernel-shared/print-tree.c
>> @@ -1721,6 +1721,7 @@ static struct readable_flag_entry
>> super_flags_array[] = {
>>       DEF_HEADER_FLAG_ENTRY(WRITTEN),
>>       DEF_HEADER_FLAG_ENTRY(RELOC),
>>       DEF_SUPER_FLAG_ENTRY(CHANGING_FSID),
>> +    DEF_SUPER_FLAG_ENTRY(CHANGING_FSID_V2),
>>       DEF_SUPER_FLAG_ENTRY(SEEDING),
>>       DEF_SUPER_FLAG_ENTRY(METADUMP),
>>       DEF_SUPER_FLAG_ENTRY(METADUMP_V2)