Re: [PATCH 3/3] btrfs-progs: add extent buffer leak detection to make test

[Josef Bacik <josef@toxicpanda.com>]

On Tue, Sep 05, 2023 at 10:49:56PM +0200, David Sterba wrote:
> On Tue, Sep 05, 2023 at 04:21:53PM -0400, Josef Bacik wrote:
> > I introduced a regression where we were leaking extent buffers, and this
> > resulted in the CI failing because we were spewing these errors.
> > 
> > Instead of waiting for fstests to catch my mistakes, check every command
> > output for leak messages, and fail the test if we detect any of these
> > messages.  I've made this generic enough that we could check for other
> > debug messages in the future.
> > 
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> 
> There already is a script to verify more than just the error leaks, I've
> added it to all the test type running scripts so it would fail.
> > ---
> >  tests/common | 108 +++++++++++++++++++++++++++++----------------------
> >  1 file changed, 61 insertions(+), 47 deletions(-)
> > 
> > diff --git a/tests/common b/tests/common
> > index 602a4122..607ad747 100644
> > --- a/tests/common
> > +++ b/tests/common
> > @@ -160,6 +160,18 @@ _is_target_command()
> >  	return 1
> >  }
> >  
> > +# Check to see if there's any debug messages that may mean we have a problem.
> > +_check_output()
> > +{
> > +	local results="$1"
> > +
> > +	if grep -q "extent buffer leak" "$results"; then
> > +		_fail "extent buffer leak reported"
> 
> There's more than that we'd like to catch, see tests/scan-results.sh.

Yup I prefer your solution, you can ignore this patch.  Thanks,

Josef