From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/3] btrfs-progs: add eb leak detection and fixes
Date: Tue, 5 Sep 2023 16:21:50 -0400 [thread overview]
Message-ID: <cover.1693945163.git.josef@toxicpanda.com> (raw)
Hello,
I introduced an EB leak that we only discovered when we started running fstests
with my code applied to the btrfs-progs devel branch. We really want to detect
this before we start using this code for fstests, so update all the run_check
related helpers to use a helper that will check for extent buffer leaks and fail
accordingly. This will allow developers to discover they've introduced a
problem when they run make test after their changes.
This functionality of course uncovered a few leaks that currently exist in
btrfs-progs, so there are two fixes that precede the leak detection work in
order to make sure we are clean from the leak detection commit ondwards.
Thanks,
Josef
Josef Bacik (3):
btrfs-progs: cleanup dirty buffers on transaction abort
btrfs-progs: properly cleanup aborted transactions in check
btrfs-progs: add extent buffer leak detection to make test
check/main.c | 10 +++-
kernel-shared/transaction.c | 45 ++++++++-------
tests/common | 108 ++++++++++++++++++++----------------
3 files changed, 95 insertions(+), 68 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-05 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 20:21 Josef Bacik [this message]
2023-09-05 20:21 ` [PATCH 1/3] btrfs-progs: cleanup dirty buffers on transaction abort Josef Bacik
2023-09-05 22:53 ` Qu Wenruo
2023-09-05 20:21 ` [PATCH 2/3] btrfs-progs: properly cleanup aborted transactions in check Josef Bacik
2023-09-05 22:55 ` Qu Wenruo
2023-09-06 13:34 ` Josef Bacik
2023-09-05 20:21 ` [PATCH 3/3] btrfs-progs: add extent buffer leak detection to make test Josef Bacik
2023-09-05 20:49 ` David Sterba
2023-09-06 13:52 ` Josef Bacik
2023-09-05 22:57 ` Qu Wenruo
2023-09-07 13:32 ` David Sterba
2023-09-08 12:08 ` [PATCH 0/3] btrfs-progs: add eb leak detection and fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1693945163.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox