Re: [PATCH 3/3] btrfs-progs: add extent buffer leak detection to make test

[David Sterba <dsterba@suse.cz>]

On Wed, Sep 06, 2023 at 06:57:55AM +0800, Qu Wenruo wrote:
> 
> 
> On 2023/9/6 04:21, Josef Bacik wrote:
> > I introduced a regression where we were leaking extent buffers, and this
> > resulted in the CI failing because we were spewing these errors.
> >
> > Instead of waiting for fstests to catch my mistakes, check every command
> > output for leak messages, and fail the test if we detect any of these
> > messages.  I've made this generic enough that we could check for other
> > debug messages in the future.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> 
> Another solution is to make debug build of btrfs-progs more noisy when
> eb leak is detected.
> 
> Instead of a graceful exit (which is suitable for release build), a
> noisy BUG_ON()/ASSERT() would definitely catch our attention, and
> requires less work in the test framework.

The eb leak checks are in the kernel-shared directory that does not
share much with the debugging helpers in the other code. Eg. the message
helpers, so we can't even grep for ERROR in the logs when there are no
supposed to be seen.