From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"wangyugui@e16-tech.com" <wangyugui@e16-tech.com>
Subject: Re: [PATCH 2/2] btrfs: detect multi-dev stripe and disable automatic inline checksum
Date: Mon, 22 Jan 2024 22:11:50 +0100 [thread overview]
Message-ID: <20240122211150.GC31555@twin.jikos.cz> (raw)
In-Reply-To: <fb44aa48-fd5d-4b3b-ae87-2ad0d9648b44@wdc.com>
On Fri, Jan 19, 2024 at 03:29:13PM +0000, Johannes Thumshirn wrote:
> On 18.01.24 09:55, Naohiro Aota wrote:
> > +static void check_striped_block_group(struct btrfs_fs_info *info, u64 type, int num_stripes)
> > +{
> > + if (btrfs_raid_array[btrfs_bg_flags_to_raid_index(type)].devs_max != 0 ||
> > + num_stripes <= BTRFS_INLINE_CSUM_MAX_DEVS)
> > + return;
> > +
> > + /*
> > + * Found a block group writing to multiple devices, disable
> > + * inline automatic checksum.
> > + */
> > + info->fs_devices->striped_writing = true;
> > +}
> > +
>
> This function adds some overly long lines.
The line length limits are not strict and checkpatch has been updated
from 80 to 100, so it's up to our taste. For the prototypes it's around
85-ish to be ok.
next prev parent reply other threads:[~2024-01-22 21:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:54 [PATCH 0/2] btrfs: disable inline checksum for multi-dev striped FS Naohiro Aota
2024-01-18 8:54 ` [PATCH 1/2] btrfs: introduce inline_csum_mode to tweak inline checksum behavior Naohiro Aota
2024-01-18 8:54 ` [PATCH 2/2] btrfs: detect multi-dev stripe and disable automatic inline checksum Naohiro Aota
2024-01-19 15:29 ` Johannes Thumshirn
2024-01-22 8:02 ` Naohiro Aota
2024-01-22 21:11 ` David Sterba [this message]
2024-01-18 9:12 ` [PATCH 0/2] btrfs: disable inline checksum for multi-dev striped FS Roman Mamedov
2024-01-19 15:49 ` David Sterba
2024-01-22 15:31 ` Naohiro Aota
2024-01-22 7:17 ` Naohiro Aota
2024-01-19 15:30 ` Johannes Thumshirn
2024-01-19 16:01 ` David Sterba
2024-01-22 15:12 ` Naohiro Aota
2024-01-22 21:19 ` David Sterba
2024-01-24 0:19 ` Wang Yugui
2024-01-29 12:56 ` Wang Yugui
2024-01-30 1:38 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122211150.GC31555@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox