From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Cc: "wangyugui@e16-tech.com" <wangyugui@e16-tech.com>
Subject: Re: [PATCH 2/2] btrfs: detect multi-dev stripe and disable automatic inline checksum
Date: Fri, 19 Jan 2024 15:29:13 +0000 [thread overview]
Message-ID: <fb44aa48-fd5d-4b3b-ae87-2ad0d9648b44@wdc.com> (raw)
In-Reply-To: <7ce85c808b96be3c8352ffa03fedbaacf0dc6d27.1705568050.git.naohiro.aota@wdc.com>
On 18.01.24 09:55, Naohiro Aota wrote:
> +static void check_striped_block_group(struct btrfs_fs_info *info, u64 type, int num_stripes)
> +{
> + if (btrfs_raid_array[btrfs_bg_flags_to_raid_index(type)].devs_max != 0 ||
> + num_stripes <= BTRFS_INLINE_CSUM_MAX_DEVS)
> + return;
> +
> + /*
> + * Found a block group writing to multiple devices, disable
> + * inline automatic checksum.
> + */
> + info->fs_devices->striped_writing = true;
> +}
> +
This function adds some overly long lines.
next prev parent reply other threads:[~2024-01-19 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:54 [PATCH 0/2] btrfs: disable inline checksum for multi-dev striped FS Naohiro Aota
2024-01-18 8:54 ` [PATCH 1/2] btrfs: introduce inline_csum_mode to tweak inline checksum behavior Naohiro Aota
2024-01-18 8:54 ` [PATCH 2/2] btrfs: detect multi-dev stripe and disable automatic inline checksum Naohiro Aota
2024-01-19 15:29 ` Johannes Thumshirn [this message]
2024-01-22 8:02 ` Naohiro Aota
2024-01-22 21:11 ` David Sterba
2024-01-18 9:12 ` [PATCH 0/2] btrfs: disable inline checksum for multi-dev striped FS Roman Mamedov
2024-01-19 15:49 ` David Sterba
2024-01-22 15:31 ` Naohiro Aota
2024-01-22 7:17 ` Naohiro Aota
2024-01-19 15:30 ` Johannes Thumshirn
2024-01-19 16:01 ` David Sterba
2024-01-22 15:12 ` Naohiro Aota
2024-01-22 21:19 ` David Sterba
2024-01-24 0:19 ` Wang Yugui
2024-01-29 12:56 ` Wang Yugui
2024-01-30 1:38 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb44aa48-fd5d-4b3b-ae87-2ad0d9648b44@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox