[PATCH] generic/733: disable for btrfs

[PATCH] generic/733: disable for btrfs

[David Sterba]

This tests if a clone source can be read but in btrfs there's an
exclusive lock and the test always fails. The functionality might be
implemented in btrfs in the future but for now disable the test.

CC: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
 tests/generic/733 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/733 b/tests/generic/733
index d88d92a4705add..b26fa47dad776f 100755
--- a/tests/generic/733
+++ b/tests/generic/733
@@ -18,7 +18,7 @@ _begin_fstest auto clone punch
 . ./common/reflink
 
 # real QA test starts here
-_supported_fs generic
+_supported_fs generic ^btrfs
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fpunch"
-- 
2.42.1

Re: [PATCH] generic/733: disable for btrfs

[Filipe Manana]

On Thu, Feb 22, 2024 at 9:51 AM David Sterba <dsterba@suse.com> wrote:
>
> This tests if a clone source can be read but in btrfs there's an
> exclusive lock and the test always fails. The functionality might be
> implemented in btrfs in the future but for now disable the test.
>
> CC: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Looks good, thanks.

> ---
>  tests/generic/733 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/733 b/tests/generic/733
> index d88d92a4705add..b26fa47dad776f 100755
> --- a/tests/generic/733
> +++ b/tests/generic/733
> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>  . ./common/reflink
>
>  # real QA test starts here
> -_supported_fs generic
> +_supported_fs generic ^btrfs
>  _require_scratch_reflink
>  _require_cp_reflink
>  _require_xfs_io_command "fpunch"
> --
> 2.42.1
>
>

Re: [PATCH] generic/733: disable for btrfs

[Wang Yugui]

Hi,

> This tests if a clone source can be read but in btrfs there's an
> exclusive lock and the test always fails. The functionality might be
> implemented in btrfs in the future but for now disable the test.

On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to
success now.  Is this expected?

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2024/02/24

> CC: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>  tests/generic/733 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/733 b/tests/generic/733
> index d88d92a4705add..b26fa47dad776f 100755
> --- a/tests/generic/733
> +++ b/tests/generic/733
> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>  . ./common/reflink
>  
>  # real QA test starts here
> -_supported_fs generic
> +_supported_fs generic ^btrfs
>  _require_scratch_reflink
>  _require_cp_reflink
>  _require_xfs_io_command "fpunch"
> -- 
> 2.42.1
> 

Re: [PATCH] generic/733: disable for btrfs

[Zorro Lang]

On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote:
> This tests if a clone source can be read but in btrfs there's an
> exclusive lock and the test always fails. The functionality might be
> implemented in btrfs in the future but for now disable the test.
> 
> CC: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>  tests/generic/733 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/733 b/tests/generic/733
> index d88d92a4705add..b26fa47dad776f 100755
> --- a/tests/generic/733
> +++ b/tests/generic/733
> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>  . ./common/reflink
>  
>  # real QA test starts here
> -_supported_fs generic
> +_supported_fs generic ^btrfs

If only need a blacklist, you can write "^btrfs" directly, e.g.

  _supported_fs ^btrfs

then others (except btrfs) are in whitelist, don't need the "generic".

Thanks,
Zorro

>  _require_scratch_reflink
>  _require_cp_reflink
>  _require_xfs_io_command "fpunch"
> -- 
> 2.42.1
> 
> 

Re: [PATCH] generic/733: disable for btrfs

[David Sterba]

On Sat, Feb 24, 2024 at 09:42:42PM +0800, Wang Yugui wrote:
> Hi,
> 
> > This tests if a clone source can be read but in btrfs there's an
> > exclusive lock and the test always fails. The functionality might be
> > implemented in btrfs in the future but for now disable the test.
> 
> On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to
> success now.  Is this expected?

The test may succeed because of lucky timing, but otherwise it's not
relevant for btrfs.

Re: [PATCH] generic/733: disable for btrfs

[David Sterba]

On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote:
> On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote:
> > This tests if a clone source can be read but in btrfs there's an
> > exclusive lock and the test always fails. The functionality might be
> > implemented in btrfs in the future but for now disable the test.
> > 
> > CC: Josef Bacik <josef@toxicpanda.com>
> > Signed-off-by: David Sterba <dsterba@suse.com>
> > ---
> >  tests/generic/733 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/733 b/tests/generic/733
> > index d88d92a4705add..b26fa47dad776f 100755
> > --- a/tests/generic/733
> > +++ b/tests/generic/733
> > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
> >  . ./common/reflink
> >  
> >  # real QA test starts here
> > -_supported_fs generic
> > +_supported_fs generic ^btrfs
> 
> If only need a blacklist, you can write "^btrfs" directly, e.g.
> 
>   _supported_fs ^btrfs
> 
> then others (except btrfs) are in whitelist, don't need the "generic".

Ok thanks, do I need to resend or would you update the commit?

Re: [PATCH] generic/733: disable for btrfs

[Zorro Lang]

On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote:
> On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote:
> > On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote:
> > > This tests if a clone source can be read but in btrfs there's an
> > > exclusive lock and the test always fails. The functionality might be
> > > implemented in btrfs in the future but for now disable the test.
> > > 
> > > CC: Josef Bacik <josef@toxicpanda.com>
> > > Signed-off-by: David Sterba <dsterba@suse.com>
> > > ---
> > >  tests/generic/733 | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/generic/733 b/tests/generic/733
> > > index d88d92a4705add..b26fa47dad776f 100755
> > > --- a/tests/generic/733
> > > +++ b/tests/generic/733
> > > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
> > >  . ./common/reflink
> > >  
> > >  # real QA test starts here
> > > -_supported_fs generic
> > > +_supported_fs generic ^btrfs
> > 
> > If only need a blacklist, you can write "^btrfs" directly, e.g.
> > 
> >   _supported_fs ^btrfs
> > 
> > then others (except btrfs) are in whitelist, don't need the "generic".
> 
> Ok thanks, do I need to resend or would you update the commit?

I can help to change that, it's simple enough.

Thanks,
Zorro

> 

Re: [PATCH] generic/733: disable for btrfs

[David Sterba]

On Tue, Apr 09, 2024 at 10:49:12PM +0800, Anand Jain wrote:
> On 2/27/24 02:07, Zorro Lang wrote:
> > On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote:
> >> On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote:
> >>> On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote:
> >>>> This tests if a clone source can be read but in btrfs there's an
> >>>> exclusive lock and the test always fails. The functionality might be
> >>>> implemented in btrfs in the future but for now disable the test.
> >>>>
> >>>> CC: Josef Bacik <josef@toxicpanda.com>
> >>>> Signed-off-by: David Sterba <dsterba@suse.com>
> >>>> ---
> >>>>   tests/generic/733 | 2 +-
> >>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/tests/generic/733 b/tests/generic/733
> >>>> index d88d92a4705add..b26fa47dad776f 100755
> >>>> --- a/tests/generic/733
> >>>> +++ b/tests/generic/733
> >>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
> >>>>   . ./common/reflink
> >>>>   
> >>>>   # real QA test starts here
> >>>> -_supported_fs generic
> >>>> +_supported_fs generic ^btrfs
> >>>
> >>> If only need a blacklist, you can write "^btrfs" directly, e.g.
> >>>
> >>>    _supported_fs ^btrfs
> >>>
> >>> then others (except btrfs) are in whitelist, don't need the "generic".
> >>
> >> Ok thanks, do I need to resend or would you update the commit?
> > 
> > I can help to change that, it's simple enough.
> > 
> 
> Applied for the PR with this changed.

The test generic/733 works after patch

https://lore.kernel.org/linux-btrfs/5fe82cceb3b6f3434172a7fb0e85a21a2f07e99c.1711199153.git.fdmanana@suse.com/

so please keep it.

Re: [PATCH] generic/733: disable for btrfs

[Anand Jain]

On 2/27/24 02:07, Zorro Lang wrote:
> On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote:
>> On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote:
>>> On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote:
>>>> This tests if a clone source can be read but in btrfs there's an
>>>> exclusive lock and the test always fails. The functionality might be
>>>> implemented in btrfs in the future but for now disable the test.
>>>>
>>>> CC: Josef Bacik <josef@toxicpanda.com>
>>>> Signed-off-by: David Sterba <dsterba@suse.com>
>>>> ---
>>>>   tests/generic/733 | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/generic/733 b/tests/generic/733
>>>> index d88d92a4705add..b26fa47dad776f 100755
>>>> --- a/tests/generic/733
>>>> +++ b/tests/generic/733
>>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>>>>   . ./common/reflink
>>>>   
>>>>   # real QA test starts here
>>>> -_supported_fs generic
>>>> +_supported_fs generic ^btrfs
>>>
>>> If only need a blacklist, you can write "^btrfs" directly, e.g.
>>>
>>>    _supported_fs ^btrfs
>>>
>>> then others (except btrfs) are in whitelist, don't need the "generic".
>>
>> Ok thanks, do I need to resend or would you update the commit?
> 
> I can help to change that, it's simple enough.
> 

Applied for the PR with this changed.

Thanks, Anand

> Thanks,
> Zorro
> 
>>
> 

Re: [PATCH] generic/733: disable for btrfs

[Anand Jain]

>>>>>> This tests if a clone source can be read but in btrfs there's an
>>>>>> exclusive lock and the test always fails. The functionality might be
>>>>>> implemented in btrfs in the future but for now disable the test.
>>>>>>
>>>>>> CC: Josef Bacik <josef@toxicpanda.com>
>>>>>> Signed-off-by: David Sterba <dsterba@suse.com>
>>>>>> ---
>>>>>>    tests/generic/733 | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/tests/generic/733 b/tests/generic/733
>>>>>> index d88d92a4705add..b26fa47dad776f 100755
>>>>>> --- a/tests/generic/733
>>>>>> +++ b/tests/generic/733
>>>>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch
>>>>>>    . ./common/reflink
>>>>>>    
>>>>>>    # real QA test starts here
>>>>>> -_supported_fs generic
>>>>>> +_supported_fs generic ^btrfs
>>>>>
>>>>> If only need a blacklist, you can write "^btrfs" directly, e.g.
>>>>>
>>>>>     _supported_fs ^btrfs
>>>>>
>>>>> then others (except btrfs) are in whitelist, don't need the "generic".
>>>>
>>>> Ok thanks, do I need to resend or would you update the commit?
>>>
>>> I can help to change that, it's simple enough.
>>>
>>
>> Applied for the PR with this changed.
> 
> The test generic/733 works after patch
> 
> https://lore.kernel.org/linux-btrfs/5fe82cceb3b6f3434172a7fb0e85a21a2f07e99c.1711199153.git.fdmanana@suse.com/
> 
> so please keep it.

Ah, appreciate the heads-up!

Thanks, Anand