* [PATCH] generic/733: disable for btrfs
@ 2024-02-22 9:50 David Sterba
2024-02-22 11:34 ` Filipe Manana
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: David Sterba @ 2024-02-22 9:50 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, David Sterba, Josef Bacik
This tests if a clone source can be read but in btrfs there's an
exclusive lock and the test always fails. The functionality might be
implemented in btrfs in the future but for now disable the test.
CC: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
tests/generic/733 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/733 b/tests/generic/733
index d88d92a4705add..b26fa47dad776f 100755
--- a/tests/generic/733
+++ b/tests/generic/733
@@ -18,7 +18,7 @@ _begin_fstest auto clone punch
. ./common/reflink
# real QA test starts here
-_supported_fs generic
+_supported_fs generic ^btrfs
_require_scratch_reflink
_require_cp_reflink
_require_xfs_io_command "fpunch"
--
2.42.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] generic/733: disable for btrfs 2024-02-22 9:50 [PATCH] generic/733: disable for btrfs David Sterba @ 2024-02-22 11:34 ` Filipe Manana 2024-02-24 13:42 ` Wang Yugui 2024-02-25 15:41 ` Zorro Lang 2 siblings, 0 replies; 10+ messages in thread From: Filipe Manana @ 2024-02-22 11:34 UTC (permalink / raw) To: David Sterba; +Cc: fstests, linux-btrfs, Josef Bacik On Thu, Feb 22, 2024 at 9:51 AM David Sterba <dsterba@suse.com> wrote: > > This tests if a clone source can be read but in btrfs there's an > exclusive lock and the test always fails. The functionality might be > implemented in btrfs in the future but for now disable the test. > > CC: Josef Bacik <josef@toxicpanda.com> > Signed-off-by: David Sterba <dsterba@suse.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Looks good, thanks. > --- > tests/generic/733 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/733 b/tests/generic/733 > index d88d92a4705add..b26fa47dad776f 100755 > --- a/tests/generic/733 > +++ b/tests/generic/733 > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > . ./common/reflink > > # real QA test starts here > -_supported_fs generic > +_supported_fs generic ^btrfs > _require_scratch_reflink > _require_cp_reflink > _require_xfs_io_command "fpunch" > -- > 2.42.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-22 9:50 [PATCH] generic/733: disable for btrfs David Sterba 2024-02-22 11:34 ` Filipe Manana @ 2024-02-24 13:42 ` Wang Yugui 2024-02-26 10:14 ` David Sterba 2024-02-25 15:41 ` Zorro Lang 2 siblings, 1 reply; 10+ messages in thread From: Wang Yugui @ 2024-02-24 13:42 UTC (permalink / raw) To: David Sterba; +Cc: fstests, linux-btrfs, Josef Bacik Hi, > This tests if a clone source can be read but in btrfs there's an > exclusive lock and the test always fails. The functionality might be > implemented in btrfs in the future but for now disable the test. On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to success now. Is this expected? Best Regards Wang Yugui (wangyugui@e16-tech.com) 2024/02/24 > CC: Josef Bacik <josef@toxicpanda.com> > Signed-off-by: David Sterba <dsterba@suse.com> > --- > tests/generic/733 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/733 b/tests/generic/733 > index d88d92a4705add..b26fa47dad776f 100755 > --- a/tests/generic/733 > +++ b/tests/generic/733 > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > . ./common/reflink > > # real QA test starts here > -_supported_fs generic > +_supported_fs generic ^btrfs > _require_scratch_reflink > _require_cp_reflink > _require_xfs_io_command "fpunch" > -- > 2.42.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-24 13:42 ` Wang Yugui @ 2024-02-26 10:14 ` David Sterba 0 siblings, 0 replies; 10+ messages in thread From: David Sterba @ 2024-02-26 10:14 UTC (permalink / raw) To: Wang Yugui; +Cc: David Sterba, fstests, linux-btrfs, Josef Bacik On Sat, Feb 24, 2024 at 09:42:42PM +0800, Wang Yugui wrote: > Hi, > > > This tests if a clone source can be read but in btrfs there's an > > exclusive lock and the test always fails. The functionality might be > > implemented in btrfs in the future but for now disable the test. > > On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to > success now. Is this expected? The test may succeed because of lucky timing, but otherwise it's not relevant for btrfs. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-22 9:50 [PATCH] generic/733: disable for btrfs David Sterba 2024-02-22 11:34 ` Filipe Manana 2024-02-24 13:42 ` Wang Yugui @ 2024-02-25 15:41 ` Zorro Lang 2024-02-26 11:33 ` David Sterba 2 siblings, 1 reply; 10+ messages in thread From: Zorro Lang @ 2024-02-25 15:41 UTC (permalink / raw) To: David Sterba; +Cc: fstests, linux-btrfs, Josef Bacik On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote: > This tests if a clone source can be read but in btrfs there's an > exclusive lock and the test always fails. The functionality might be > implemented in btrfs in the future but for now disable the test. > > CC: Josef Bacik <josef@toxicpanda.com> > Signed-off-by: David Sterba <dsterba@suse.com> > --- > tests/generic/733 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/733 b/tests/generic/733 > index d88d92a4705add..b26fa47dad776f 100755 > --- a/tests/generic/733 > +++ b/tests/generic/733 > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > . ./common/reflink > > # real QA test starts here > -_supported_fs generic > +_supported_fs generic ^btrfs If only need a blacklist, you can write "^btrfs" directly, e.g. _supported_fs ^btrfs then others (except btrfs) are in whitelist, don't need the "generic". Thanks, Zorro > _require_scratch_reflink > _require_cp_reflink > _require_xfs_io_command "fpunch" > -- > 2.42.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-25 15:41 ` Zorro Lang @ 2024-02-26 11:33 ` David Sterba 2024-02-26 18:07 ` Zorro Lang 0 siblings, 1 reply; 10+ messages in thread From: David Sterba @ 2024-02-26 11:33 UTC (permalink / raw) To: Zorro Lang; +Cc: David Sterba, fstests, linux-btrfs, Josef Bacik On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote: > On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote: > > This tests if a clone source can be read but in btrfs there's an > > exclusive lock and the test always fails. The functionality might be > > implemented in btrfs in the future but for now disable the test. > > > > CC: Josef Bacik <josef@toxicpanda.com> > > Signed-off-by: David Sterba <dsterba@suse.com> > > --- > > tests/generic/733 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/generic/733 b/tests/generic/733 > > index d88d92a4705add..b26fa47dad776f 100755 > > --- a/tests/generic/733 > > +++ b/tests/generic/733 > > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > > . ./common/reflink > > > > # real QA test starts here > > -_supported_fs generic > > +_supported_fs generic ^btrfs > > If only need a blacklist, you can write "^btrfs" directly, e.g. > > _supported_fs ^btrfs > > then others (except btrfs) are in whitelist, don't need the "generic". Ok thanks, do I need to resend or would you update the commit? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-26 11:33 ` David Sterba @ 2024-02-26 18:07 ` Zorro Lang 2024-04-09 14:49 ` Anand Jain 0 siblings, 1 reply; 10+ messages in thread From: Zorro Lang @ 2024-02-26 18:07 UTC (permalink / raw) To: David Sterba; +Cc: David Sterba, fstests, linux-btrfs, Josef Bacik On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote: > On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote: > > On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote: > > > This tests if a clone source can be read but in btrfs there's an > > > exclusive lock and the test always fails. The functionality might be > > > implemented in btrfs in the future but for now disable the test. > > > > > > CC: Josef Bacik <josef@toxicpanda.com> > > > Signed-off-by: David Sterba <dsterba@suse.com> > > > --- > > > tests/generic/733 | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/generic/733 b/tests/generic/733 > > > index d88d92a4705add..b26fa47dad776f 100755 > > > --- a/tests/generic/733 > > > +++ b/tests/generic/733 > > > @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > > > . ./common/reflink > > > > > > # real QA test starts here > > > -_supported_fs generic > > > +_supported_fs generic ^btrfs > > > > If only need a blacklist, you can write "^btrfs" directly, e.g. > > > > _supported_fs ^btrfs > > > > then others (except btrfs) are in whitelist, don't need the "generic". > > Ok thanks, do I need to resend or would you update the commit? I can help to change that, it's simple enough. Thanks, Zorro > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-02-26 18:07 ` Zorro Lang @ 2024-04-09 14:49 ` Anand Jain 2024-04-09 14:46 ` David Sterba 0 siblings, 1 reply; 10+ messages in thread From: Anand Jain @ 2024-04-09 14:49 UTC (permalink / raw) To: Zorro Lang, David Sterba; +Cc: David Sterba, fstests, linux-btrfs, Josef Bacik On 2/27/24 02:07, Zorro Lang wrote: > On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote: >> On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote: >>> On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote: >>>> This tests if a clone source can be read but in btrfs there's an >>>> exclusive lock and the test always fails. The functionality might be >>>> implemented in btrfs in the future but for now disable the test. >>>> >>>> CC: Josef Bacik <josef@toxicpanda.com> >>>> Signed-off-by: David Sterba <dsterba@suse.com> >>>> --- >>>> tests/generic/733 | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tests/generic/733 b/tests/generic/733 >>>> index d88d92a4705add..b26fa47dad776f 100755 >>>> --- a/tests/generic/733 >>>> +++ b/tests/generic/733 >>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch >>>> . ./common/reflink >>>> >>>> # real QA test starts here >>>> -_supported_fs generic >>>> +_supported_fs generic ^btrfs >>> >>> If only need a blacklist, you can write "^btrfs" directly, e.g. >>> >>> _supported_fs ^btrfs >>> >>> then others (except btrfs) are in whitelist, don't need the "generic". >> >> Ok thanks, do I need to resend or would you update the commit? > > I can help to change that, it's simple enough. > Applied for the PR with this changed. Thanks, Anand > Thanks, > Zorro > >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-04-09 14:49 ` Anand Jain @ 2024-04-09 14:46 ` David Sterba 2024-04-09 15:01 ` Anand Jain 0 siblings, 1 reply; 10+ messages in thread From: David Sterba @ 2024-04-09 14:46 UTC (permalink / raw) To: Anand Jain Cc: Zorro Lang, David Sterba, David Sterba, fstests, linux-btrfs, Josef Bacik On Tue, Apr 09, 2024 at 10:49:12PM +0800, Anand Jain wrote: > On 2/27/24 02:07, Zorro Lang wrote: > > On Mon, Feb 26, 2024 at 12:33:40PM +0100, David Sterba wrote: > >> On Sun, Feb 25, 2024 at 11:41:23PM +0800, Zorro Lang wrote: > >>> On Thu, Feb 22, 2024 at 10:50:48AM +0100, David Sterba wrote: > >>>> This tests if a clone source can be read but in btrfs there's an > >>>> exclusive lock and the test always fails. The functionality might be > >>>> implemented in btrfs in the future but for now disable the test. > >>>> > >>>> CC: Josef Bacik <josef@toxicpanda.com> > >>>> Signed-off-by: David Sterba <dsterba@suse.com> > >>>> --- > >>>> tests/generic/733 | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/tests/generic/733 b/tests/generic/733 > >>>> index d88d92a4705add..b26fa47dad776f 100755 > >>>> --- a/tests/generic/733 > >>>> +++ b/tests/generic/733 > >>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch > >>>> . ./common/reflink > >>>> > >>>> # real QA test starts here > >>>> -_supported_fs generic > >>>> +_supported_fs generic ^btrfs > >>> > >>> If only need a blacklist, you can write "^btrfs" directly, e.g. > >>> > >>> _supported_fs ^btrfs > >>> > >>> then others (except btrfs) are in whitelist, don't need the "generic". > >> > >> Ok thanks, do I need to resend or would you update the commit? > > > > I can help to change that, it's simple enough. > > > > Applied for the PR with this changed. The test generic/733 works after patch https://lore.kernel.org/linux-btrfs/5fe82cceb3b6f3434172a7fb0e85a21a2f07e99c.1711199153.git.fdmanana@suse.com/ so please keep it. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] generic/733: disable for btrfs 2024-04-09 14:46 ` David Sterba @ 2024-04-09 15:01 ` Anand Jain 0 siblings, 0 replies; 10+ messages in thread From: Anand Jain @ 2024-04-09 15:01 UTC (permalink / raw) To: dsterba; +Cc: Zorro Lang, David Sterba, fstests, linux-btrfs, Josef Bacik >>>>>> This tests if a clone source can be read but in btrfs there's an >>>>>> exclusive lock and the test always fails. The functionality might be >>>>>> implemented in btrfs in the future but for now disable the test. >>>>>> >>>>>> CC: Josef Bacik <josef@toxicpanda.com> >>>>>> Signed-off-by: David Sterba <dsterba@suse.com> >>>>>> --- >>>>>> tests/generic/733 | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/tests/generic/733 b/tests/generic/733 >>>>>> index d88d92a4705add..b26fa47dad776f 100755 >>>>>> --- a/tests/generic/733 >>>>>> +++ b/tests/generic/733 >>>>>> @@ -18,7 +18,7 @@ _begin_fstest auto clone punch >>>>>> . ./common/reflink >>>>>> >>>>>> # real QA test starts here >>>>>> -_supported_fs generic >>>>>> +_supported_fs generic ^btrfs >>>>> >>>>> If only need a blacklist, you can write "^btrfs" directly, e.g. >>>>> >>>>> _supported_fs ^btrfs >>>>> >>>>> then others (except btrfs) are in whitelist, don't need the "generic". >>>> >>>> Ok thanks, do I need to resend or would you update the commit? >>> >>> I can help to change that, it's simple enough. >>> >> >> Applied for the PR with this changed. > > The test generic/733 works after patch > > https://lore.kernel.org/linux-btrfs/5fe82cceb3b6f3434172a7fb0e85a21a2f07e99c.1711199153.git.fdmanana@suse.com/ > > so please keep it. Ah, appreciate the heads-up! Thanks, Anand ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-04-09 15:01 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-22 9:50 [PATCH] generic/733: disable for btrfs David Sterba 2024-02-22 11:34 ` Filipe Manana 2024-02-24 13:42 ` Wang Yugui 2024-02-26 10:14 ` David Sterba 2024-02-25 15:41 ` Zorro Lang 2024-02-26 11:33 ` David Sterba 2024-02-26 18:07 ` Zorro Lang 2024-04-09 14:49 ` Anand Jain 2024-04-09 14:46 ` David Sterba 2024-04-09 15:01 ` Anand Jain
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox