From: David Sterba <dsterba@suse.cz>
To: Srivathsa Dara <srivathsa.d.dara@oracle.com>
Cc: linux-btrfs@vger.kernel.org,
rajesh.sivaramasubramaniom@oracle.com, junxiao.bi@oracle.com,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Subject: Re: [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support
Date: Thu, 30 May 2024 19:46:25 +0200 [thread overview]
Message-ID: <20240530174625.GD25460@twin.jikos.cz> (raw)
In-Reply-To: <20240530053754.4115449-1-srivathsa.d.dara@oracle.com>
On Thu, May 30, 2024 at 05:37:54AM +0000, Srivathsa Dara wrote:
> In ext4, number of blocks can be greater than 2^32. Therefore, if
> btrfs-convert is used on filesystems greater than or equal to 16TiB
> (Staring from 16TiB, number of blocks overflow 32 bits), it fails to
> convert.
>
> Example:
>
> Here, /dev/sdc1 is 16TiB partition intitialized with an ext4 filesystem.
>
> [root@rasivara-arm2 opc]# btrfs-convert -d -p /dev/sdc1
> btrfs-convert from btrfs-progs v5.15.1
>
> convert/main.c:1164: do_convert: Assertion `cctx.total_bytes != 0` failed, value 0
> btrfs-convert(+0xfd04)[0xaaaaba44fd04]
> btrfs-convert(main+0x258)[0xaaaaba44d278]
> /lib64/libc.so.6(__libc_start_main+0xdc)[0xffffb962777c]
> btrfs-convert(+0xd4fc)[0xaaaaba44d4fc]
> Aborted (core dumped)
>
> Fix it by considering 64 bit block numbers.
>
> Signed-off-by: Srivathsa Dara <srivathsa.d.dara@oracle.com>
The current conver tests passed, can you please also send test case for
this fix? Thanks.
next prev parent reply other threads:[~2024-05-30 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 5:37 [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support Srivathsa Dara
2024-05-30 11:00 ` Anand Jain
2024-05-30 17:45 ` David Sterba
2024-05-30 17:29 ` David Sterba
2024-05-31 9:04 ` Srivathsa Dara
2024-05-31 15:33 ` David Sterba
2024-06-03 10:42 ` [External] : " Srivathsa Dara
2024-05-30 17:46 ` David Sterba [this message]
2024-05-31 8:58 ` Srivathsa Dara
2024-05-31 15:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530174625.GD25460@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=srivathsa.d.dara@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox