From: David Sterba <dsterba@suse.cz>
To: Srivathsa Dara <srivathsa.d.dara@oracle.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Rajesh Sivaramasubramaniom
<rajesh.sivaramasubramaniom@oracle.com>,
Junxiao Bi <junxiao.bi@oracle.com>, "clm@fb.com" <clm@fb.com>,
"josef@toxicpanda.com" <josef@toxicpanda.com>,
"dsterba@suse.com" <dsterba@suse.com>
Subject: Re: [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support
Date: Fri, 31 May 2024 17:33:16 +0200 [thread overview]
Message-ID: <20240531153316.GE25460@suse.cz> (raw)
In-Reply-To: <DM6PR10MB43476059C588E8136707F28DA0FC2@DM6PR10MB4347.namprd10.prod.outlook.com>
On Fri, May 31, 2024 at 09:04:13AM +0000, Srivathsa Dara wrote:
> > > @@ -46,7 +46,7 @@ struct btrfs_trans_handle; #define
> > > ext2fs_get_block_bitmap_range2 ext2fs_get_block_bitmap_range #define
> > > ext2fs_inode_data_blocks2 ext2fs_inode_data_blocks #define
> > > ext2fs_read_ext_attr2 ext2fs_read_ext_attr
> > > -#define ext2fs_blocks_count(s) ((s)->s_blocks_count)
> > > +#define ext2fs_blocks_count(s) ((s)->s_blocks_count_hi << 32) | (s)->s_blocks_count
> >
> > Looks like there's missing closing )
>
> No, all parenthesis are balanced.
Oh right but it's confusing because the expression should be enclosed in
a pair of ( ) as it's an expression in a macro and it could change
result once expanded in random locations.
next prev parent reply other threads:[~2024-05-31 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 5:37 [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support Srivathsa Dara
2024-05-30 11:00 ` Anand Jain
2024-05-30 17:45 ` David Sterba
2024-05-30 17:29 ` David Sterba
2024-05-31 9:04 ` Srivathsa Dara
2024-05-31 15:33 ` David Sterba [this message]
2024-06-03 10:42 ` [External] : " Srivathsa Dara
2024-05-30 17:46 ` David Sterba
2024-05-31 8:58 ` Srivathsa Dara
2024-05-31 15:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531153316.GE25460@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=srivathsa.d.dara@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox