Re: [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support

[David Sterba <dsterba@suse.cz>]

On Fri, May 31, 2024 at 08:58:08AM +0000, Srivathsa Dara wrote:
> 
> 
> -----Original Message-----
> From: David Sterba <dsterba@suse.cz> 
> Sent: Thursday, May 30, 2024 11:16 PM
> To: Srivathsa Dara <srivathsa.d.dara@oracle.com>
> Cc: linux-btrfs@vger.kernel.org; Rajesh Sivaramasubramaniom <rajesh.sivaramasubramaniom@oracle.com>; Junxiao Bi <junxiao.bi@oracle.com>; clm@fb.com; josef@toxicpanda.com; dsterba@suse.com
> Subject: Re: [RESEND PATCH] btrfs-progs: convert: Add 64 bit block numbers support
> 
> Hi David,
> Thanks for answering Anand's question on my behalf.
> 
> > On Thu, May 30, 2024 at 05:37:54AM +0000, Srivathsa Dara wrote:
> > > In ext4, number of blocks can be greater than 2>32. Therefore, if 
> > > btrfs-convert is used on filesystems greater than or equal to 16TiB 
> > > (Staring from 16TiB, number of blocks overflow 32 bits), it fails to 
> > > convert.
> > > 
> > > Example:
> > > 
> > > Here, /dev/sdc1 is 16TiB partition intitialized with an ext4 filesystem.
> > > 
> > > [root@rasivara-arm2 opc]# btrfs-convert -d -p /dev/sdc1 btrfs-convert 
> > > from btrfs-progs v5.15.1
> > > 
> > > convert/main.c:1164: do_convert: Assertion `cctx.total_bytes != 0` 
> > > failed, value 0 btrfs-convert(+0xfd04)[0xaaaaba44fd04]
> > > btrfs-convert(main+0x258)[0xaaaaba44d278]
> > > /lib64/libc.so.6(__libc_start_main+0xdc)[0xffffb962777c]
> > > btrfs-convert(+0xd4fc)[0xaaaaba44d4fc]
> > > Aborted (core dumped)
> > > 
> > > Fix it by considering 64 bit block numbers.
> > > 
> > > Signed-off-by: Srivathsa Dara <srivathsa.d.dara@oracle.com>
> >
> > The current conver tests passed, can you please also send test case for this fix? Thanks.
> 
> Sure, would you like me to send that in v2 or as a separate patch?

Separate patch for test is ok. Thanks.