[PATCH] btrfs: add comma delimiter for zone_unusable to space_info dump

[PATCH] btrfs: add comma delimiter for zone_unusable to space_info dump

[Johannes Thumshirn]

From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

On a space_info dump all values but 'zone_unusable' are delimited by a
comma.

Add the missing comma between 'readonly' and 'zone_unusable' to be
consistent and make parsing easier.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/btrfs/space-info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index 517916004f21..a2da9b4ab3ac 100644
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -607,7 +607,7 @@ static void __btrfs_dump_space_info(const struct btrfs_fs_info *fs_info,
 		   (s64)(info->total_bytes - btrfs_space_info_used(info, true)),
 		   info->full ? "" : "not ");
 	btrfs_info(fs_info,
-"space_info total=%llu, used=%llu, pinned=%llu, reserved=%llu, may_use=%llu, readonly=%llu zone_unusable=%llu",
+"space_info total=%llu, used=%llu, pinned=%llu, reserved=%llu, may_use=%llu, readonly=%llu, zone_unusable=%llu",
 		info->total_bytes, info->bytes_used, info->bytes_pinned,
 		info->bytes_reserved, info->bytes_may_use,
 		info->bytes_readonly, info->bytes_zone_unusable);
-- 
2.49.0

Re: [PATCH] btrfs: add comma delimiter for zone_unusable to space_info dump

[David Sterba]

On Thu, Jun 05, 2025 at 05:24:31PM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> On a space_info dump all values but 'zone_unusable' are delimited by a
> comma.
> 
> Add the missing comma between 'readonly' and 'zone_unusable' to be
> consistent and make parsing easier.

So this makes it consistent with the rest of the line but is otherwise
inconsistent with the style of values printed elsewhere, ie. without the
"=" between name and value.

But it seems it's been quite inconsistent everywhere. The only place
where the style is unified is tracepoints. I'm not sure if we should do
the same in the normal syslog messges, either with the space as
delimiter or with "=". In both cases the "," can be dropped though.