Re: [PATCH 0/4] Set/get accessor cleanups

[David Sterba <dsterba@suse.cz>]

On Sun, Jun 29, 2025 at 10:48:15AM +0930, Qu Wenruo wrote:
> > David Sterba (4):
> >    btrfs: don't use token set/get accessors for btrfs_item members
> >    btrfs: don't use token set/get accessors in inode.c:fill_inode_item()
> >    btrfs: tree-log: don't use token set/get accessors in
> >      fill_inode_item()
> >    btrfs: accessors: delete token versions of set/get helpers
> 
> Looks good to me.
> 
> Reviewed-by: Qu Wenruo <wqu@suse.com>
> 
> Although it also exposed that we have two different fill_inode_item() 
> functions.
> I know the tree log code needs some special handling, the 
> fill_inode_item() in inode.c looks like can be implemented by the one in 
> tree-log.
> 
> It may be a good time to merge them into one in another patch.

Yes, the difference is not that big so it makes sense to merge them.