public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 0/4] Set/get accessor cleanups
Date: Fri, 27 Jun 2025 16:03:49 +0200	[thread overview]
Message-ID: <cover.1751032655.git.dsterba@suse.com> (raw)

This patchset is first in a series to cleanup and optimize the
accessors, now removing code that's not needed anymore, explained with
references in the last patch.

Overall effects on .ko:

   text    data     bss     dec     hex filename
1463615  115665   16088 1595368  1857e8 pre/btrfs.ko
1456601  115665   16088 1588354  183c82 post/btrfs.ko

DELTA: -7014

And stack consumption:

__push_leaf_left                                   -32 (176 -> 144)
copy_for_split                                     -32 (144 -> 112)
fill_inode_item                                    -32 (80 -> 48)
btrfs_truncate_item                                -24 (152 -> 128)
btrfs_extend_item                                  -16 (104 -> 88)
btrfs_del_items                                    -16 (144 -> 128)
setup_items_for_insert                             -32 (144 -> 112)
__push_leaf_right                                  -24 (168 -> 144)

REMOVED (744):
        btrfs_get_token_32                          88
        btrfs_set_token_64                          96
        btrfs_get_token_64                          88
        btrfs_set_token_32                          96
        btrfs_get_token_16                          88
        btrfs_get_token_8                           88
        btrfs_set_token_16                          96
        btrfs_set_token_8                           96
        btrfs_init_map_token                         8

REMOVED/NEW DELTA:  -744
PRE/POST DELTA:     -952

David Sterba (4):
  btrfs: don't use token set/get accessors for btrfs_item members
  btrfs: don't use token set/get accessors in inode.c:fill_inode_item()
  btrfs: tree-log: don't use token set/get accessors in
    fill_inode_item()
  btrfs: accessors: delete token versions of set/get helpers

 fs/btrfs/accessors.c | 78 --------------------------------------------
 fs/btrfs/accessors.h | 37 ---------------------
 fs/btrfs/ctree.c     | 51 ++++++++++-------------------
 fs/btrfs/inode.c     | 50 ++++++++++++----------------
 fs/btrfs/tree-log.c  | 48 +++++++++++----------------
 5 files changed, 57 insertions(+), 207 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-06-27 14:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 14:03 David Sterba [this message]
2025-06-27 14:03 ` [PATCH 1/4] btrfs: don't use token set/get accessors for btrfs_item members David Sterba
2025-06-27 14:03 ` [PATCH 2/4] btrfs: don't use token set/get accessors in inode.c:fill_inode_item() David Sterba
2025-06-27 14:03 ` [PATCH 3/4] btrfs: tree-log: don't use token set/get accessors in fill_inode_item() David Sterba
2025-06-27 14:03 ` [PATCH 4/4] btrfs: accessors: delete token versions of set/get helpers David Sterba
2025-06-29  1:13   ` Qu Wenruo
2025-06-30 16:11     ` David Sterba
2025-06-29  1:18 ` [PATCH 0/4] Set/get accessor cleanups Qu Wenruo
2025-06-30 15:54   ` David Sterba
2025-06-30  6:25 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1751032655.git.dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox