Re: [PATCH 4/4] btrfs: accessors: delete token versions of set/get helpers

[David Sterba <dsterba@suse.cz>]

On Sun, Jun 29, 2025 at 10:43:26AM +0930, Qu Wenruo wrote:
> 
> 
> 在 2025/6/27 23:33, David Sterba 写道:
> > Once upon a time there was a need to cache address of extent buffer
> > pages, as it was a costly operation (map_private_extent_buffer(),
> > cfed81a04eb555 ("Btrfs: add the ability to cache a pointer into the
> > eb")).  This was not even due to use of HIGHMEM, this had been removed
> > before that due to possible locking issues ( a65917156e3459 ("Btrfs:
> > stop using highmem for extent_buffers")).
> > 
> > Over the time the amount of work in the set/get helpers got reduced and
> > became quite straightforward bounds checking with an unaligned
> > read/write, commit db3756c879773c ("btrfs: remove unused
> > map_private_extent_buffer").
> 
> Thanks a lot for the history of the token accessors.
> 
> And this is also a great chance to us to sync the removal of token eb 
> accessors to the progs.
> 
> If you haven't yet started that progs removal, I'm totally fine to do that.

I usually do the kernel->progs sync before a release, inspired by the
kernel git log where it applies. I haven't started with the accessors
updates as I have a few more changes to those files pending but I
wouldn't mind if you do it now.